lib/vfscore: Solve redefining conflicts #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skuenzer
reviewed
Apr 4, 2022
This was referenced Apr 21, 2022
mogasergiu
reviewed
May 17, 2022
mogasergiu
reviewed
May 17, 2022
razvand
requested review from
skuenzer and
mogasergiu
and removed request for
a team
mogasergiu
approved these changes
Aug 14, 2022
skuenzer
requested changes
Aug 17, 2022
There was a problem hiding this comment.
Hi @dragosargint,
thanks a lot for these fixes. Can you check the few comments that I posted? It is basically concerning mkfifo and umount. We should use UK_SYSCALL_R_DEFINE for those instead. Then they are also properly registered at the syscall shim.
Thanks,
Simon
There are many functions that are defined in musl as well as in vfscore. When using musl you want to use the musl functions. When we use musl the `LIBSYSCALL_SHIM_NOWRAPPER` macro is set , which leads to the setting of `UK_LIBC_SYSCALLS` to 0. We can use this to exclude the redefined functions from vfscore. Signed-off-by: Dragos Iulian Argint <dragosargint21@gmail.com>
Signed-off-by: Dragos Iulian Argint <dragosargint21@gmail.com>
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
unikraft-bot
added
area/lib
skuenzer
approved these changes
Aug 19, 2022
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 19, 2022
Signed-off-by: Dragos Iulian Argint <dragosargint21@gmail.com> Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com> Approved-by: Simon Kuenzer <simon.kuenzer@neclab.eu> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #441
nderjung
added
the
topic/muslpreview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many functions that are defined in musl as well as in vfscore. When using
musl we want to use the musl functions. When we use musl the
LIBSYSCALL_SHIM_NOWRAPPERmacro is set, which leads to the setting of
UK_LIBC_SYSCALLSto 0. We can use thisto exclude the redefined functions from vfscore.
This PR is part of a series:
#454
#453
#442
#441
Signed-off-by: Dragos Iulian Argint dragosargint21@gmail.com