Fix spinlock headers #477
Closed
Fix spinlock headers #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spinlock main header uses the `CONFIG_HAVE_SMP` and should therefore include `uk/config.h`. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu>
Commit b85c0df ("plat/kvm/arm: Add alignament attribute to spinlock struct") introduces the `__align()` macro in the definition of the spinlock without including `essentials.h`. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu>
To ensure that required macros are defined by the spinlock implementation, we add a preprocessor check. This commit further fixes the [in,out] parameters to comply with the doxygen specification. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu>
marcrittinghaus
added
lang/c
razvanvirtan
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
All good on my side.
Reviewed-by: Răzvan Vîrtan virtanrazvan@gmail.com
|
Beep boop! I ran Unikraft's
Truncated logs starting from first warning 8970b67: View complete logs | Learn more about Unikraft's coding style and contribution guidelines. |
|
@michpappas Also here. Could you have a quick look and approve if everything is fine from your side? |
|
Approved-by: Michalis Pappas mpappas@fastmail.fm |
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 15, 2022
Commit b85c0df ("plat/kvm/arm: Add alignament attribute to spinlock struct") introduces the `__align()` macro in the definition of the spinlock without including `essentials.h`. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu> Reviewed-by: Răzvan Vîrtan <virtanrazvan@gmail.com> Approved-by: Michalis Pappas <mpappas@fastmail.fm> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #477
unikraft-bot
pushed a commit
that referenced
this pull request
Aug 15, 2022
To ensure that required macros are defined by the spinlock implementation, we add a preprocessor check. This commit further fixes the [in,out] parameters to comply with the doxygen specification. Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu> Reviewed-by: Răzvan Vîrtan <virtanrazvan@gmail.com> Approved-by: Michalis Pappas <mpappas@fastmail.fm> Tested-by: Unikraft CI <monkey@unikraft.io> GitHub-Closes: #477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.plon your commit series before opening this PR;Base target
arm64and generic]Additional configuration
Description of changes
This PR adds some missing includes and checks to the spinlock headers as well as fixing spelling mistakes.
Thanks @Sairajkodilkar for pointing out the missing
essentials.h! 😃