lib/vfscore: Fix error return on symlink syscall #851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sys_symlink()` function returns `ENOENT` if the lookup failed, instead of the actual error code `lookup()` exited with. This may not always be right, since `lookup()` can return other error codes (for example `ELOOP`). Fix that by not setting the error code and just jump to the end of the function. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com> GitHub-Closes: unikraft#849
|
✅ Checkpatch passed Beep boop! I ran Unikraft's
|
razvand
requested review from
andraprs and
rares-miculescu
and removed request for
a team
razvand
added
plat/kvm
andraprs
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Reviewed-by: Andra Paraschiv andra@unikraft.io
Thank you for the fix. :)
marcrittinghaus
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Thanks! 😃
Approved-by: Marc Rittinghaus marc.rittinghaus@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sys_symlink()function returnsENOENTif the lookup failed, instead of the actual error codelookup()exited with. This may not always be right, sincelookup()can return other error codes (for exampleELOOP).Fix that by not setting the error code and just jump to the end of the function.
Note that for symlinks to work properly, @andraprs's PR #830 is also needed.
GitHub-Closes: #849
Prerequisite checklist
checkpatch.plon your commit series before opening this PR;Base target
x86_64kvm