New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APNS memory leak: remove the request info when timeout #25

Closed
monnand opened this Issue Jul 3, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@monnand
Member

monnand commented Jul 3, 2013

APNS may not reply any message on success (esp. for sandbox environment). We have a time out mechanism to make sure to reply a status to the client. However, on time out, we will never delete the request information which is stored as an element in map[uint32]*pushRequest. The size of this map will keep increasing if the sandbox environment was used.

The related code could be found in srv/apns.go:apnsPushService.pushWorker(). It might be the cause of OOM mentioned in #24.

@monnand

This comment has been minimized.

Show comment
Hide comment
@monnand

monnand Jul 7, 2013

Member

fixed

Member

monnand commented Jul 7, 2013

fixed

@monnand monnand closed this Jul 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment