Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gives guard expressions access to variables #333

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@francisdb
Copy link
Contributor

francisdb commented Feb 11, 2019

fixes #327

@pchiusano I tried adding a test case to test/Termparser.hs but it did not trigger the issue. Are there any similar tests that also invoke the TypeChecker to trigger this issue?

@pchiusano

This comment has been minimized.

Copy link
Member

pchiusano commented Feb 11, 2019

@francisdb Excellent!! You can just add a .u file to unison-src/tests - all .u files in that directory will get parsed and typechecked. Could you add that as part of this PR and also add yourself to CONTRIBUTORS file? :)

@francisdb francisdb force-pushed the francisdb:caseguard branch from 16cc28e to 427f423 Feb 12, 2019

@pchiusano

This comment has been minimized.

Copy link
Member

pchiusano commented Feb 13, 2019

👍 thanks @francisdb

@pchiusano pchiusano merged commit eaca7a6 into unisonweb:master Feb 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.