fix(sketch): improve file path extraction in markdown tables #465

Enhances the regex and logic for extracting file paths from backticked markdown content, supporting more path formats and ensuring correct file detection. Also adjusts UI for file open button and PlantUML diagram sizing.

Author: phodal

mpp-ui/src/jvmMain/kotlin/cc/unitmesh/devins/ui/compose/sketch/MarkdownTableRenderer.kt

@@ -22,6 +22,7 @@ import androidx.compose.ui.unit.Dp
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.times
 import cc.unitmesh.devins.ui.compose.icons.AutoDevComposeIcons
+import cc.unitmesh.devins.ui.platform.FileChooser
 import com.mikepenz.markdown.annotator.AnnotatorSettings
 import com.mikepenz.markdown.annotator.annotatorSettings
 import com.mikepenz.markdown.annotator.buildMarkdownAnnotatedString
@@ -158,7 +159,10 @@ fun MarkdownTableHeader(
         modifier = Modifier.widthIn(tableWidth).height(IntrinsicSize.Max)
     ) {
         header.children.filter { it.type == CELL }.forEachIndexed { idx, cell ->
-            val weight = if (weights.size == header.children.count { it.type == CELL }) weights[idx] else 1f / (header.children.count { it.type == CELL }).coerceAtLeast(1)
+            val weight =
+                if (weights.size == header.children.count { it.type == CELL }) weights[idx] else 1f / (header.children.count { it.type == CELL }).coerceAtLeast(
+                    1
+                )
             Column(
                 modifier = Modifier.padding(tableCellPadding).weight(weight),
             ) {
@@ -221,6 +225,19 @@ fun MarkdownTableRow(
                     val filePath = extractBacktickedPath(raw)
                     if (filePath != null) {
                         Row(verticalAlignment = Alignment.CenterVertically) {
+                            IconButton(
+                                modifier = Modifier.size(16.dp),
+                                onClick = {
+                                    val root = WorkspaceManager.getCurrentOrEmpty().rootPath
+                                    val abs = if (root != null) root + "/" + filePath else filePath
+                                    onOpenFile(abs)
+                                }) {
+                                Icon(
+                                    modifier = Modifier.size(16.dp),
+                                    imageVector = AutoDevComposeIcons.Visibility, contentDescription = "View File"
+                                )
+                            }
+                            Spacer(modifier = Modifier.width(4.dp))
                             MarkdownTableBasicText(
                                 content = content,
                                 cell = cell,
@@ -229,14 +246,6 @@ fun MarkdownTableRow(
                                 overflow = overflow,
                                 annotatorSettings = annotatorSettings
                             )
-                            Spacer(modifier = Modifier.width(4.dp))
-                            IconButton(onClick = {
-                                val root = WorkspaceManager.getCurrentOrEmpty().rootPath
-                                val abs = if (root != null) root + "/" + filePath else filePath
-                                onOpenFile(abs)
-                            }) {
-                                Icon(imageVector = AutoDevComposeIcons.Visibility, contentDescription = "View File")
-                            }
                         }
                     } else {
                         MarkdownTableBasicText(
@@ -277,9 +286,23 @@ fun MarkdownTableBasicText(
 
 /**
  * Extract backticked file path from markdown cell content
+ * Supports paths like:
+ * - `mpp-core/.../CodeReviewArtifact.kt`
+ * - `src/main/kotlin/MyFile.kt`
+ * - `path/to/file-name_v2.kt`
  */
 private fun extractBacktickedPath(raw: String): String? {
-    val pathRegex = Regex("`([\\w\\-./]+)`")
+    // Match backticked content that looks like a file path
+    // Supports: alphanumeric, dots, slashes, hyphens, underscores, ellipsis (...), brackets, parentheses
+    val pathRegex = Regex("`([\\w\\-_./@()\\[\\]]+(?:\\.{3})?[\\w\\-_./@()\\[\\]]*)`")
     val match = pathRegex.find(raw)
-    return match?.groupValues?.getOrNull(1)
+    val candidate = match?.groupValues?.getOrNull(1)
+
+    // Filter: must contain at least one slash or a file extension
+    return if (candidate != null && (candidate.contains('/') || candidate.contains('.'))) {
+        // Expand ellipsis if present (e.g., mpp-core/.../File.kt -> mpp-core/src/.../File.kt)
+        candidate
+    } else {
+        null
+    }
 }

mpp-ui/src/jvmMain/kotlin/cc/unitmesh/devins/ui/compose/sketch/PlantUmlRenderer.kt

@@ -1,23 +1,10 @@
 package cc.unitmesh.devins.ui.compose.sketch
 
-import androidx.compose.foundation.layout.Box
-import androidx.compose.foundation.layout.fillMaxWidth
-import androidx.compose.foundation.layout.padding
-import androidx.compose.foundation.layout.size
+import androidx.compose.foundation.layout.*
 import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.filled.Download
-import androidx.compose.material3.CircularProgressIndicator
-import androidx.compose.material3.DropdownMenu
-import androidx.compose.material3.DropdownMenuItem
-import androidx.compose.material3.Icon
-import androidx.compose.material3.IconButton
-import androidx.compose.material3.Text
-import androidx.compose.runtime.Composable
-import androidx.compose.runtime.LaunchedEffect
-import androidx.compose.runtime.getValue
-import androidx.compose.runtime.mutableStateOf
-import androidx.compose.runtime.remember
-import androidx.compose.runtime.setValue
+import androidx.compose.material3.*
+import androidx.compose.runtime.*
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
@@ -105,7 +92,8 @@ fun PlantUmlRenderer(
                         bitmap = bitmap,
                         contentDescription = "PlantUML Diagram",
                         contentScale = ContentScale.Fit,
-                        modifier = Modifier.Companion.fillMaxWidth()
+                        modifier = Modifier.fillMaxWidth()
+                            .widthIn(min = 400.dp)
                     )
 
                     // Download button overlay (always visible)