Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyLightning now depends on tensorboardx (previously tensorboard) #1386

Merged
merged 1 commit into from Nov 25, 2022

Conversation

madtoinou
Copy link
Collaborator

@madtoinou madtoinou commented Nov 25, 2022

Fixes #.

Summary

Pytorch-Lightning changed dependency from tensorboard to tensorboardX (PR #15728), propagating the change to darts.

Other Information

Looked for tensorboard import everywhere, only found it in the notebooks, I hope that I did not miss anything.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

Codecov Report

Base: 93.94% // Head: 93.93% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (cad3d28) compared to base (02eaad5).
Patch has no changes to coverable lines.

❗ Current head cad3d28 differs from pull request most recent head e4f731e. Consider uploading reports for the commit e4f731e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
- Coverage   93.94%   93.93%   -0.01%     
==========================================
  Files          80       80              
  Lines        8708     8696      -12     
==========================================
- Hits         8181     8169      -12     
  Misses        527      527              
Impacted Files Coverage Δ
darts/timeseries.py 92.16% <0.00%> (-0.06%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 87.70% <0.00%> (-0.06%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.27% <0.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hrzn hrzn merged commit e347e98 into master Nov 25, 2022
@madtoinou madtoinou deleted the fix/tensorboardx-dependency branch March 12, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants