-
Notifications
You must be signed in to change notification settings - Fork 522
Added in some missing legislator social accounts, updated some names #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -2970,7 +2971,8 @@ | |||
- S8MN00438 | |||
cspan: 23334 | |||
name: | |||
first: Al | |||
first: Alan | |||
middle: Stuart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense, but you'll want to add a "nickname" field with "Al", since that's what he goes by and what most people will want to display.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
I'm going through the social media names now (it's amazing so many have been added since I swept a couple weeks ago). There's a few we won't accept yet in there - these things always require manual verification. twitter.com/KellyAyotte - Her official page doesn't actually link to it (it's in the source code but not used) and the account doesn't link back to her official page. It looks official, but I really want to see at least a visible link on her homepage. facebook.com/brianschatz, twitter.com/brianschatz - His page doesn't link to it, it's commented out. Amy Klobuchar's Twitter and Facebook - she doesn't link to either on her homepage, only her YouTube account. facebook.com/CongressmanRaulRuizMD - it looks right, but the official homepage for Rep. Ruiz links to a bad account instead. Still, without the homepage linkage, this one's not ready yet. I don't want to add those accounts to the blacklist and forget about them, since I think it's likely they'll become their official, linked-to accounts. But they should be ignored, and deleted from the CSV before running the twitter.com/PatrickMurphyFL - it's a campaign account. Patrick Murphy's actual site includes a couple links to it, but also a couple links to his real one, RepMurphyFL. I'll add this to the blacklist. Jeff Flake's facebook.com/154010926645 didn't work for me when I visited it. His homepage still links to his campaign Facebook account, so let's leave this one blank for now. The rest look good to me! |
If you want to change this pull request, or file a new one, to just be the names file changes, I can merge it right away. If you don't mind, I'm happy to make all the social media changes myself, since I already went through and have the data ready to update myself. |
Actually, that might be tough, I'm on the move - so if you don't mind just scrapping the accounts I pointed out, and replacing the Murphy account with the one I suggested, I can merge that one too. |
Added! Sorry, didn't know those requirements. |
@@ -1264,7 +1265,7 @@ | |||
thomas: '01744' | |||
govtrack: 400285 | |||
social: | |||
twitter: RepTimMurphy | |||
twitter: RepMurphyFL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you changed the wrong one - I meant PatrickMurphyFL was the campaign account, to be changed to RepMurphyFL. So many Murphys! if you can change that, I'll merge this in, rest looks great.
Huge thanks for doing this!
Yeah - I should document those requirements, that's my bad. |
Added in some missing legislator social accounts, updated some names
Merged! Thanks again. So how'd you come to our shores? Are you using this data anywhere? |
Thanks Eric! I'm using the data for a non-profit wanting to do some advocacy work. Do you know of any state-level resources for state legislators? |
Not in this project, but you might take a look at OpenStates.org. -- Eric
|
Update legislators-district-offices.yaml fixes #39
No description provided.