Added in some missing legislator social accounts, updated some names #39

Merged
merged 4 commits into from Feb 24, 2013

Conversation

Projects
None yet
2 participants
@webster
Contributor

webster commented Feb 23, 2013

No description provided.

@@ -2970,7 +2971,8 @@
- S8MN00438
cspan: 23334
name:
- first: Al
+ first: Alan
+ middle: Stuart

This comment has been minimized.

@konklone

konklone Feb 24, 2013

Member

This makes sense, but you'll want to add a "nickname" field with "Al", since that's what he goes by and what most people will want to display.

@konklone

konklone Feb 24, 2013

Member

This makes sense, but you'll want to add a "nickname" field with "Al", since that's what he goes by and what most people will want to display.

This comment has been minimized.

@webster

webster Feb 24, 2013

Contributor

Fixed!

@webster

webster Feb 24, 2013

Contributor

Fixed!

@konklone

This comment has been minimized.

Show comment
Hide comment
@konklone

konklone Feb 24, 2013

Member

I'm going through the social media names now (it's amazing so many have been added since I swept a couple weeks ago). There's a few we won't accept yet in there - these things always require manual verification.

twitter.com/KellyAyotte - Her official page doesn't actually link to it (it's in the source code but not used) and the account doesn't link back to her official page. It looks official, but I really want to see at least a visible link on her homepage.

facebook.com/brianschatz, twitter.com/brianschatz - His page doesn't link to it, it's commented out.

Amy Klobuchar's Twitter and Facebook - she doesn't link to either on her homepage, only her YouTube account.

facebook.com/CongressmanRaulRuizMD - it looks right, but the official homepage for Rep. Ruiz links to a bad account instead. Still, without the homepage linkage, this one's not ready yet.

I don't want to add those accounts to the blacklist and forget about them, since I think it's likely they'll become their official, linked-to accounts. But they should be ignored, and deleted from the CSV before running the --update script.

twitter.com/PatrickMurphyFL - it's a campaign account. Patrick Murphy's actual site includes a couple links to it, but also a couple links to his real one, RepMurphyFL. I'll add this to the blacklist.

Jeff Flake's facebook.com/154010926645 didn't work for me when I visited it. His homepage still links to his campaign Facebook account, so let's leave this one blank for now.

The rest look good to me!

Member

konklone commented Feb 24, 2013

I'm going through the social media names now (it's amazing so many have been added since I swept a couple weeks ago). There's a few we won't accept yet in there - these things always require manual verification.

twitter.com/KellyAyotte - Her official page doesn't actually link to it (it's in the source code but not used) and the account doesn't link back to her official page. It looks official, but I really want to see at least a visible link on her homepage.

facebook.com/brianschatz, twitter.com/brianschatz - His page doesn't link to it, it's commented out.

Amy Klobuchar's Twitter and Facebook - she doesn't link to either on her homepage, only her YouTube account.

facebook.com/CongressmanRaulRuizMD - it looks right, but the official homepage for Rep. Ruiz links to a bad account instead. Still, without the homepage linkage, this one's not ready yet.

I don't want to add those accounts to the blacklist and forget about them, since I think it's likely they'll become their official, linked-to accounts. But they should be ignored, and deleted from the CSV before running the --update script.

twitter.com/PatrickMurphyFL - it's a campaign account. Patrick Murphy's actual site includes a couple links to it, but also a couple links to his real one, RepMurphyFL. I'll add this to the blacklist.

Jeff Flake's facebook.com/154010926645 didn't work for me when I visited it. His homepage still links to his campaign Facebook account, so let's leave this one blank for now.

The rest look good to me!

@konklone

This comment has been minimized.

Show comment
Hide comment
@konklone

konklone Feb 24, 2013

Member

If you want to change this pull request, or file a new one, to just be the names file changes, I can merge it right away. If you don't mind, I'm happy to make all the social media changes myself, since I already went through and have the data ready to update myself.

Member

konklone commented Feb 24, 2013

If you want to change this pull request, or file a new one, to just be the names file changes, I can merge it right away. If you don't mind, I'm happy to make all the social media changes myself, since I already went through and have the data ready to update myself.

@konklone

This comment has been minimized.

Show comment
Hide comment
@konklone

konklone Feb 24, 2013

Member

Actually, that might be tough, I'm on the move - so if you don't mind just scrapping the accounts I pointed out, and replacing the Murphy account with the one I suggested, I can merge that one too.

Member

konklone commented Feb 24, 2013

Actually, that might be tough, I'm on the move - so if you don't mind just scrapping the accounts I pointed out, and replacing the Murphy account with the one I suggested, I can merge that one too.

@webster

This comment has been minimized.

Show comment
Hide comment
@webster

webster Feb 24, 2013

Contributor

Added! Sorry, didn't know those requirements.

Contributor

webster commented Feb 24, 2013

Added! Sorry, didn't know those requirements.

legislators-social-media.yaml
@@ -1264,7 +1265,7 @@
thomas: '01744'
govtrack: 400285
social:
- twitter: RepTimMurphy
+ twitter: RepMurphyFL

This comment has been minimized.

@konklone

konklone Feb 24, 2013

Member

Oops, you changed the wrong one - I meant PatrickMurphyFL was the campaign account, to be changed to RepMurphyFL. So many Murphys! if you can change that, I'll merge this in, rest looks great.

Huge thanks for doing this!

@konklone

konklone Feb 24, 2013

Member

Oops, you changed the wrong one - I meant PatrickMurphyFL was the campaign account, to be changed to RepMurphyFL. So many Murphys! if you can change that, I'll merge this in, rest looks great.

Huge thanks for doing this!

@konklone

This comment has been minimized.

Show comment
Hide comment
@konklone

konklone Feb 24, 2013

Member

Yeah - I should document those requirements, that's my bad.

Member

konklone commented Feb 24, 2013

Yeah - I should document those requirements, that's my bad.

konklone added a commit that referenced this pull request Feb 24, 2013

Merge pull request #39 from webster/master
Added in some missing legislator social accounts, updated some names

@konklone konklone merged commit a70e1ed into unitedstates:master Feb 24, 2013

@konklone

This comment has been minimized.

Show comment
Hide comment
@konklone

konklone Feb 24, 2013

Member

Merged! Thanks again. So how'd you come to our shores? Are you using this data anywhere?

Member

konklone commented Feb 24, 2013

Merged! Thanks again. So how'd you come to our shores? Are you using this data anywhere?

@webster

This comment has been minimized.

Show comment
Hide comment
@webster

webster Feb 24, 2013

Contributor

Thanks Eric! I'm using the data for a non-profit wanting to do some advocacy work. Do you know of any state-level resources for state legislators?

Contributor

webster commented Feb 24, 2013

Thanks Eric! I'm using the data for a non-profit wanting to do some advocacy work. Do you know of any state-level resources for state legislators?

@konklone

This comment has been minimized.

Show comment
Hide comment
@konklone

konklone Feb 24, 2013

Member

Not in this project, but you might take a look at OpenStates.org.

-- Eric
On Feb 24, 2013 3:34 PM, "Tony Webster" notifications@github.com wrote:

Thanks Eric! I'm using the data for a non-profit wanting to do some
advocacy work. Do you know of any state-level resources for state
legislators?


Reply to this email directly or view it on GitHubhttps://github.com/unitedstates/congress-legislators/pull/39#issuecomment-14015412.

Member

konklone commented Feb 24, 2013

Not in this project, but you might take a look at OpenStates.org.

-- Eric
On Feb 24, 2013 3:34 PM, "Tony Webster" notifications@github.com wrote:

Thanks Eric! I'm using the data for a non-profit wanting to do some
advocacy work. Do you know of any state-level resources for state
legislators?


Reply to this email directly or view it on GitHubhttps://github.com/unitedstates/congress-legislators/pull/39#issuecomment-14015412.

konklone pushed a commit that referenced this pull request Oct 25, 2017

Merge pull request #41 from arrighik/patch-2
Update legislators-district-offices.yaml
fixes #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment