Add Pressure valves - #10433
Merged
Merged
Conversation
MaxIsJoe
requested changes
Jul 9, 2024
Bod9001
reviewed
Jul 10, 2024
|
|
||
| Vector2 pressureDensity = pipeData.mixAndVolume.Density(); | ||
|
|
||
| if (inputDensity.x - pressureDensity.x > ThresholdPressure || inputDensity.y - pressureDensity.y > ThresholdPressure) |
Member
There was a problem hiding this comment.
technically the pressure between reagent and gas is different, in terms of common values, it's fine for now , we probably need to think of what is a better way of displaying the pressure for reagents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pressure valves, which are essentially just valves that only pass gas if the input pipenet is above the set pressure (default of 101.325kpa, can be changed to whatever using the nettab), also requires a pressure difference between the input and output of 10kpa
Also fixes the volume pump overclock sprites, the manual valve sprites and speeds up the overclock animation a little bit
And also fixes an issue with the air injector fittings sprite being rotated incorrectly occasionally
Changelog:
CL: [New] Adds pressure valves.