GitHub Actions: create a tag to our repo weekly if a new change is committed since last tagging #2655

masatake · 2020-10-03T21:52:40Z

Partially close #1038.

~~The tagging format is v5.9.YYYYMMDD.0~~.
The tagging format is p5.9.YYYYMMDD.0.

coveralls · 2020-10-03T21:55:50Z

Coverage remained the same at 86.998% when pulling e9baeff on masatake:weekly-git-tagging into d93b1a8 on universal-ctags:master.

.github/workflows/tagging.yml

k-takata

Maybe we should update src/ctags.h and configure.ac to 5.9.0?
(If they are updated, tests should be also updated, though...)

.github/workflows/tagging.yml

misc/git-tag-maybe.sh

masatake · 2020-10-06T04:50:18Z

Maybe we should update src/ctags.h and configure.ac to 5.9.0?
(If they are updated, tests should be also updated, though...)

Do you mean updating the version strings in the files WHEN tagging?

k-takata · 2020-10-06T05:02:11Z

I think it's better to set the major and the minor numbers to the same as the tag name.
I don't want to say that the patch number should be updated on every tagging.

masatake · 2020-10-06T15:54:25Z

@k-takata, thank you for reviewing. I updated this pull request.
I cherry-pick'ed the @albfan's work.

I have a question.

win32/ctags.exe.manifest:  <assemblyIdentity type="win32" name="Universal Ctags" version="0.0.0.0" />
win32/ctags.rc:            VALUE "FileVersion", "0.0.0.0"
win32/ctags.rc:            VALUE "ProductVersion", "0.0.0.0"
``

Should I update these files? If the answer is yes, how? "5.9.0.0" is o.k.?

k-takata · 2020-10-06T15:58:01Z

Should I update these files? If the answer is yes, how? "5.9.0.0" is o.k.?

Yes, "5.9.0.0" should be okay.

masatake · 2020-10-06T16:06:33Z

@k-takata,
Could you see b34696f, the change for win32?

k-takata · 2020-10-07T09:12:30Z

Could you see b34696f, the change for win32?

Looks okay.

k-takata · 2020-10-07T09:36:08Z

misc/git-tag-maybe.sh

+desc=$(git describe --tags --always)
+case "${desc}" in
+	v*)


This may not work as expected.
If once v5.9.20201007.0 was tagged and some commits were added, git describe --tags --always would return v5.9.20201007.0-N-gHHHHHHH. (N is a number of commits from the last tag, HHHHHHH is the commit ID.)
If --exact-match option is specified, git describe will fail if the current commit is not tagged.

Thank you. I tried --exact-match but it seems to me that the optoin doesn't work expectedly:

$ git describe --tags --always 9ce35430 $ git tag x $ git describe --exact-match fatal: no tag exactly matches '9ce35430b0866d055fb18090d85bd00c1dea43d0' $ echo $? 128 $ git describe --tags --always x

How about pattern

v*.0)

instead of v* ?
Too stingy?

How about git describe --tags --exact-match?

masatake · 2020-10-08T04:17:28Z

I decide to use p instead of v. I would like to reserve v for the future.
p means Peridoical.

masatake · 2020-10-08T04:22:56Z

The change of prefix must be written in a new blog entry.

codecov · 2020-10-08T04:29:42Z

Codecov Report

Merging #2655 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2655   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         183      183           
  Lines       39016    39018    +2     
=======================================
+ Hits        33906    33908    +2     
  Misses       5110     5110

Impacted Files	Coverage Δ
main/parse.c	`95.09% <0.00%> (-0.01%)`	⬇️
main/ptag.c	`93.58% <0.00%> (+0.25%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e852ee0...e9baeff. Read the comment docs.

@masatake

Updated to 5.9.0. @masatake updated some more files. @masatake edited this commit log.

…in32 related files) Updated to 5.9.0.

@k-takata

…mmitted since last tagging Partially close universal-ctags#1038. The tagging format is p5.9.YYYYMMDD.0. @k-takata helped me utilize git describe/tag.

masatake · 2020-10-09T20:45:29Z

Simplified the commits.

masatake · 2020-10-09T21:06:33Z

Let's see what happens in this Sunday.

masatake · 2020-10-09T21:07:24Z

5.9.0 are hard-coded in many places. I must reduce them.

masatake requested a review from k-takata October 3, 2020 21:53

masatake mentioned this pull request Oct 3, 2020

Release plans ? #1038

Closed

masatake commented Oct 3, 2020

View reviewed changes

.github/workflows/tagging.yml Outdated Show resolved Hide resolved

k-takata reviewed Oct 6, 2020

View reviewed changes

.github/workflows/tagging.yml Outdated Show resolved Hide resolved

misc/git-tag-maybe.sh Outdated Show resolved Hide resolved

masatake force-pushed the weekly-git-tagging branch from 1d5a7c7 to 457ebbb Compare October 6, 2020 15:51

masatake mentioned this pull request Oct 6, 2020

Update version #2362

Closed

k-takata reviewed Oct 7, 2020

View reviewed changes

masatake changed the title ~~GitHub action: create a tag to our repo weekly if a new change is committed since last tagging~~ GitHub actions: create a tag to our repo weekly if a new change is committed since last tagging Oct 8, 2020

masatake changed the title ~~GitHub actions: create a tag to our repo weekly if a new change is committed since last tagging~~ GitHub Actions: create a tag to our repo weekly if a new change is committed since last tagging Oct 8, 2020

albfan and others added 3 commits October 10, 2020 05:37

Tmain,build-sys: update version for automatic periodic git tagging

5911c7c

Updated to 5.9.0. @masatake updated some more files. @masatake edited this commit log.

build-sys,win32: update version for automatic periodic git tagging (w…

419852b

…in32 related files) Updated to 5.9.0.

GitHub Actions: create a tag to our repo weekly if a new change is co…

e9baeff

…mmitted since last tagging Partially close universal-ctags#1038. The tagging format is p5.9.YYYYMMDD.0. @k-takata helped me utilize git describe/tag.

masatake force-pushed the weekly-git-tagging branch from 50914c4 to e9baeff Compare October 9, 2020 20:44

masatake merged commit a111a61 into universal-ctags:master Oct 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Actions: create a tag to our repo weekly if a new change is committed since last tagging #2655

GitHub Actions: create a tag to our repo weekly if a new change is committed since last tagging #2655

masatake commented Oct 3, 2020 •

edited

coveralls commented Oct 3, 2020 •

edited

k-takata left a comment

masatake commented Oct 6, 2020

k-takata commented Oct 6, 2020

masatake commented Oct 6, 2020

k-takata commented Oct 6, 2020

masatake commented Oct 6, 2020

k-takata commented Oct 7, 2020

k-takata Oct 7, 2020

masatake Oct 7, 2020

k-takata Oct 7, 2020

masatake commented Oct 8, 2020

masatake commented Oct 8, 2020

codecov bot commented Oct 8, 2020 •

edited

masatake commented Oct 9, 2020

masatake commented Oct 9, 2020

masatake commented Oct 9, 2020

GitHub Actions: create a tag to our repo weekly if a new change is committed since last tagging #2655

GitHub Actions: create a tag to our repo weekly if a new change is committed since last tagging #2655

Conversation

masatake commented Oct 3, 2020 • edited

coveralls commented Oct 3, 2020 • edited

k-takata left a comment

Choose a reason for hiding this comment

masatake commented Oct 6, 2020

k-takata commented Oct 6, 2020

masatake commented Oct 6, 2020

k-takata commented Oct 6, 2020

masatake commented Oct 6, 2020

k-takata commented Oct 7, 2020

k-takata Oct 7, 2020

Choose a reason for hiding this comment

masatake Oct 7, 2020

Choose a reason for hiding this comment

k-takata Oct 7, 2020

Choose a reason for hiding this comment

masatake commented Oct 8, 2020

masatake commented Oct 8, 2020

codecov bot commented Oct 8, 2020 • edited

Codecov Report

masatake commented Oct 9, 2020

masatake commented Oct 9, 2020

masatake commented Oct 9, 2020

masatake commented Oct 3, 2020 •

edited

coveralls commented Oct 3, 2020 •

edited

codecov bot commented Oct 8, 2020 •

edited