Skip to content

use srcset for higher res images on smart #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2015
Merged

use srcset for higher res images on smart #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions springboard_iogt/templates/molecules/page_listing.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
{% set has_image = page.image and page.image_host %}
{% if image_first and has_image %}
<a href="{{ 'page'|route_url(uuid=page.uuid) }}">
<img alt="{{ page.title }}" src="{{ page.image_host }}{{ page.image|thumbor(140) }}"/>
<img alt="{{ page.title }}" src="{{ page.image_host }}{{ page.image|thumbor(140) }}" srcset="{{page.image_host}}{{page.image|thumbor(320)}} 320w" sizes="100vw" />
</a>
{% endif %}
<div class="h2">
<a href="{{ 'page'|route_url(uuid=page.uuid) }}">{{page.title}}</a>
</div>
{% if not image_first and has_image %}
<a href="{{ 'page'|route_url(uuid=page.uuid) }}">
<img alt="{{ page.title }}" src="{{ page.image_host }}{{ page.image|thumbor(140) }}"/>
<img alt="{{ page.title }}" src="{{ page.image_host }}{{ page.image|thumbor(140) }}" srcset="{{page.image_host}}{{page.image|thumbor(320)}} 320w" sizes="100vw" />
</a>
{% endif %}
<p>{{ page.description|markdown }}</p>
Expand Down
2 changes: 1 addition & 1 deletion springboard_iogt/templates/molecules/section_heading.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% macro section_banner(section, localisation) -%}
<div class="section-banner {{ section.slug }}">
{%- if localisation and localisation.image_host and localisation.image -%}
<img alt="{% trans owner=section.owner %}Brought to you by {{ owner }}{% endtrans %}" src="{{ localisation.image_host }}{{ localisation.image|thumbor(140) }}"/>
<img alt="{% trans owner=section.owner %}Brought to you by {{ owner }}{% endtrans %}" src="{{ localisation.image_host }}{{ localisation.image|thumbor(140) }}" srcset="{{localisation.image_host}}{{localisation.image|thumbor(320)}} 320w" sizes="100vw" />
{%- else -%}
<img alt="{% trans owner=section.owner %}Brought to you by {{ owner }}{% endtrans %}" src="{{ ('springboard_iogt:static/img/banner_%s.jpg' % section.slug)|static_url }}" />
{%- endif -%}
Expand Down
2 changes: 1 addition & 1 deletion springboard_iogt/templates/page.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
{% if has_image %}
<div class="img">
<a href="{{'page'|route_url(uuid=page.uuid)}}">
<img alt="{{page.title}}" src="{{page.image_host}}{{page.image|thumbor(140)}}"/>
<img alt="{{page.title}}" src="{{page.image_host}}{{page.image|thumbor(140)}}" srcset="{{page.image_host}}{{page.image|thumbor(320)}} 320w" sizes="100vw" />
</a>
</div>
{% endif %}
Expand Down