set persona value on GA #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@miltontony @smn I've done some reading and I don't think we can get around using a custom dimension to track a user's persona on GA. Do we control this GA account? Any other suggestions? |
Contributor
Author
|
@miltontony @smn ready for review. I couldn't make up my mind about the GA implementation. So I added support for a custom dimension while putting the persona value in the GA path query string. Happy to change this. |
Conflicts: springboard_iogt/views.py
Contributor
|
👍 |
|
We control our GA domains so we should be able to set the custom dimensions / tags via the API. |
Contributor
Author
|
I'm going to leave that for later. Until then, the query string hack should be good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.