From a1bed67590d2ecfefac90b1cd9c794dd64ca1082 Mon Sep 17 00:00:00 2001
From: Simon de Haan <simon@praekeltfoundation.org>
Date: Fri, 22 May 2015 12:06:59 +0200
Subject: [PATCH 1/9] cleaning things up a bit, now with 2 new errors, mount
 your refactorcats. You are welcome @nathanbegbie.

---
 springboard/templates/base.jinja2          |  4 +--
 springboard/templates/locale_change.jinja2 |  2 +-
 springboard/tests/test_language.py         | 16 +++++----
 springboard/tests/test_views.py            |  3 +-
 springboard/views.py                       | 39 ++++++++--------------
 5 files changed, 28 insertions(+), 36 deletions(-)

diff --git a/springboard/templates/base.jinja2 b/springboard/templates/base.jinja2
index 8184134..abe95f6 100644
--- a/springboard/templates/base.jinja2
+++ b/springboard/templates/base.jinja2
@@ -14,9 +14,9 @@
     <div id="header">
         <div class="lang">
             <div>
-                {% for lang_code, lang_name in display_languages %}
+                {% for lang_code, lang_name in display_languages.items() %}
                 <li>
-                    <a href="{{'locale_matched'|route_url(language=lang_code)"}}>{{lang_name}}</a>
+                    <a href="{{'locale_matched'|route_url(language=lang_code)}}">{{lang_name}}</a>
                 </li>
                 {% endfor %}
                     <li><a href="{{'locale_change'|route_url}}">&gt;&gt;</a></li>
diff --git a/springboard/templates/locale_change.jinja2 b/springboard/templates/locale_change.jinja2
index e33b1f6..993dc47 100644
--- a/springboard/templates/locale_change.jinja2
+++ b/springboard/templates/locale_change.jinja2
@@ -3,7 +3,7 @@
 {% block content %}
 
 <ul>
-{% for lang_code, lang_name in view.get_available_languages() %}
+{% for lang_code, lang_name in available_languages.items() %}
 	<li>
 		<a href="{{'locale_matched'|route_url(language=lang_code) }}">{{lang_name}}</a>
 	</li>
diff --git a/springboard/tests/test_language.py b/springboard/tests/test_language.py
index fccc6b8..6b397f2 100644
--- a/springboard/tests/test_language.py
+++ b/springboard/tests/test_language.py
@@ -7,16 +7,18 @@ class TestLanguages(SpringboardTestCase):
 
     def setUp(self):
         self.workspace = self.mk_workspace()
-
-        languages = ("[('eng_GB', 'English'), ('swa_KE', 'Swahili'),"
-                     "('spa_ES', 'Spanish')]")
-        featured_langs = "[('spa_ES', 'Spanish'), ('eng_GB', 'English')]"
-
         settings = {
             'unicore.repos_dir': self.working_dir,
             'unicore.content_repo_urls': self.workspace.working_dir,
-            'available_languages': languages,
-            'featured_languages': featured_langs
+            'available_languages': '\n'.join([
+                'eng_GB = English',
+                'swa_KE = Swahili',
+                'spa_ES = Spanish',
+            ]),
+            'featured_languages': '\n'.join([
+                'spa_ES = Spanish',
+                'eng_GB = English',
+            ])
         }
         self.config = testing.setUp(settings=settings)
         self.app = self.mk_app(self.workspace, settings=settings)
diff --git a/springboard/tests/test_views.py b/springboard/tests/test_views.py
index 0c2ca62..aa4157f 100644
--- a/springboard/tests/test_views.py
+++ b/springboard/tests/test_views.py
@@ -32,7 +32,8 @@ def test_index_view(self):
         context = views.index_view()
         self.assertEqual(set(context.keys()),
                          set(['user', 'language', 'all_categories',
-                              'all_pages']))
+                              'all_pages', 'featured_languages',
+                              'available_languages', 'display_languages']))
 
     def test_category(self):
         [category] = self.mk_categories(self.workspace, count=1)
diff --git a/springboard/views.py b/springboard/views.py
index 3dece09..cf97128 100644
--- a/springboard/views.py
+++ b/springboard/views.py
@@ -12,7 +12,8 @@
 from pyramid.httpexceptions import HTTPFound
 from pyramid.response import Response
 
-from springboard.utils import parse_repo_name, ga_context
+from springboard.utils import (
+    parse_repo_name, ga_context, config_list, config_dict)
 
 from unicore.content.models import Category, Page
 from unicore.distribute.tasks import fastforward
@@ -34,7 +35,7 @@ def __init__(self, request):
         repo_dir = self.settings.get('unicore.repos_dir', 'repos')
         repo_names = map(
             lambda repo_url: parse_repo_name(repo_url),
-            self.settings['unicore.content_repo_urls'].strip().split('\n'))
+            config_list(self.settings['unicore.content_repo_urls']))
         self.all_repo_paths = map(
             lambda repo_name: os.path.join(repo_dir, repo_name),
             repo_names)
@@ -49,10 +50,19 @@ def __init__(self, request):
         self.all_categories = SM(Category, **search_config).es(
             **self.es_settings)
         self.all_pages = SM(Page, **search_config).es(**self.es_settings)
+        self.available_languages = config_dict(
+            self.settings.get('available_languages', ''))
+        self.featured_languages = config_dict(
+            self.settings.get('featured_languages', ''))
+        self.display_languages = self.available_languages.copy()
+        self.display_languages.update(self.featured_languages)
 
     def context(self, **context):
         defaults = {
             'user': self.request.user,
+            'available_languages': self.available_languages,
+            'featured_languages': self.featured_languages,
+            'display_languages': self.display_languages,
             'language': self.language,
             'all_categories': self.all_categories,
             'all_pages': self.all_pages,
@@ -107,12 +117,7 @@ def notfound(self):
         route_name='locale_change',
         renderer='springboard:templates/locale_change.jinja2')
     def locale_change(self):
-        return self.context(
-            languages=(
-                self.get_featured_languages() +
-                sorted(list(set(self.get_available_languages()) -
-                       set(self.get_featured_languages())),
-                       key=lambda tup: tup[1].lower())))
+        return self.context()
 
     @view_config(route_name='locale')
     @view_config(route_name='locale_matched')
@@ -126,22 +131,6 @@ def set_locale_cookie(self):
 
         return HTTPFound(location='/', headers=response.headers)
 
-    def get_available_languages(self):
-        available_languages = sorted(literal_eval(
-            (self.settings.get('available_languages', '[]'))),
-            key=lambda tup: tup[1].lower())
-        return [
-            (code, self.get_display_name(code))
-            for code, name in available_languages]
-
-    def get_featured_languages(self):
-        featured_languages = sorted(literal_eval(
-            (self.settings.get('featured_languages', '[]'))),
-            key=lambda tup: tup[1].lower())
-        return [
-            (code, self.get_display_name(code))
-            for code, name in featured_languages]
-
     def get_display_name(self, locale):
         language_code, _, country_code = locale.partition('_')
         term_code = languages.get(bibliographic=language_code).terminology
@@ -150,7 +139,7 @@ def get_display_name(self, locale):
     def get_display_languages(self):
         to_display = [
             code for code, name in
-            self.get_featured_languages() or self.get_available_languages()[:2]
+            self.featured_languages or self.available_languages[:2]
         ]
 
         featured_and_current = [self.language] + sorted(list(

From 152c195c2e540d6889ab29a03c03ed54f0be9ea9 Mon Sep 17 00:00:00 2001
From: Simon de Haan <simon@praekeltfoundation.org>
Date: Fri, 22 May 2015 12:15:48 +0200
Subject: [PATCH 2/9] fixing 404 error

---
 springboard/views.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/springboard/views.py b/springboard/views.py
index cf97128..4547756 100644
--- a/springboard/views.py
+++ b/springboard/views.py
@@ -111,7 +111,7 @@ def api_notify(self):
     @notfound_view_config(renderer='springboard:templates/404.jinja2')
     def notfound(self):
         self.request.response.status = 404
-        return {}
+        return self.context()
 
     @view_config(
         route_name='locale_change',

From d0b88a7ce5e66abbb52ac689015455c544b79409 Mon Sep 17 00:00:00 2001
From: nathanbegbie <nathanbegbie@gmail.com>
Date: Fri, 22 May 2015 14:00:50 +0200
Subject: [PATCH 3/9] Created filter to render language names correctly

---
 springboard/defaults.ini                   |  1 +
 springboard/filters.py                     | 10 ++++++++++
 springboard/templates/base.jinja2          |  4 ++--
 springboard/templates/locale_change.jinja2 |  2 +-
 springboard/tests/test_language.py         |  7 +++----
 springboard/views.py                       | 14 ++------------
 6 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/springboard/defaults.ini b/springboard/defaults.ini
index 340417d..3f1f0ec 100644
--- a/springboard/defaults.ini
+++ b/springboard/defaults.ini
@@ -18,6 +18,7 @@ jinja2.filters =
     format_date = springboard.filters:format_date_filter
     thumbor = springboard.filters:thumbor_filter
     markdown = springboard.filters:markdown_filter
+    display_language_name = springboard.filters:display_language_name_filter
 
 unicorehub.host =
 unicorehub.app_id =
diff --git a/springboard/filters.py b/springboard/filters.py
index 2e018ab..3b1e2bd 100644
--- a/springboard/filters.py
+++ b/springboard/filters.py
@@ -8,6 +8,9 @@
 
 from pyramid.threadlocal import get_current_registry
 
+from babel import Locale
+from pycountry import languages
+
 
 @contextfilter
 def format_date_filter(ctx, timestamp, format):
@@ -32,3 +35,10 @@ def markdown_filter(ctx, content):
     if not content:
         return content
     return markdown(content)
+
+
+@contextfilter
+def display_language_name_filter(ctx, locale):
+    language_code, _, country_code = locale.partition('_')
+    term_code = languages.get(bibliographic=language_code).terminology
+    return Locale.parse(term_code).language_name
diff --git a/springboard/templates/base.jinja2 b/springboard/templates/base.jinja2
index abe95f6..7a3c553 100644
--- a/springboard/templates/base.jinja2
+++ b/springboard/templates/base.jinja2
@@ -14,9 +14,9 @@
     <div id="header">
         <div class="lang">
             <div>
-                {% for lang_code, lang_name in display_languages.items() %}
+                {% for lang_code, name in display_languages.items() %}
                 <li>
-                    <a href="{{'locale_matched'|route_url(language=lang_code)}}">{{lang_name}}</a>
+                    <a href="{{'locale_matched'|route_url(language=lang_code)}}">{{lang_code|display_language_name}}</a>
                 </li>
                 {% endfor %}
                     <li><a href="{{'locale_change'|route_url}}">&gt;&gt;</a></li>
diff --git a/springboard/templates/locale_change.jinja2 b/springboard/templates/locale_change.jinja2
index 993dc47..10b67bb 100644
--- a/springboard/templates/locale_change.jinja2
+++ b/springboard/templates/locale_change.jinja2
@@ -5,7 +5,7 @@
 <ul>
 {% for lang_code, lang_name in available_languages.items() %}
 	<li>
-		<a href="{{'locale_matched'|route_url(language=lang_code) }}">{{lang_name}}</a>
+		<a href="{{'locale_matched'|route_url(language=lang_code) }}">{{lang_code|display_language_name}}</a>
 	</li>
 {% endfor %}
 </ul>
diff --git a/springboard/tests/test_language.py b/springboard/tests/test_language.py
index 1a4b082..470ad57 100644
--- a/springboard/tests/test_language.py
+++ b/springboard/tests/test_language.py
@@ -68,16 +68,15 @@ def test_locales_displayed(self):
         view = SpringboardViews(self.mk_request())
         langs = view.get_display_languages()
         self.assertEqual(
-            langs, [('eng_GB', 'English'), ('spa_ES', u'espa\xf1ol')])
+            langs, ['eng_GB', 'spa_ES'])
 
         view = SpringboardViews(self.mk_request(locale_name='fre_FR'))
         langs = view.get_display_languages()
         self.assertEqual(
             langs,
-            [('fre_FR', u'fran\xe7ais'), ('eng_GB', 'English'),
-             ('spa_ES', u'espa\xf1ol')])
+            ['fre_FR', 'eng_GB', 'spa_ES'])
 
         view = SpringboardViews(self.mk_request(locale_name='spa_ES'))
         langs = view.get_display_languages()
         self.assertEqual(
-            langs, [('spa_ES', u'espa\xf1ol'), ('eng_GB', 'English')])
+            langs, ['spa_ES', 'eng_GB'])
diff --git a/springboard/views.py b/springboard/views.py
index 4547756..c022da7 100644
--- a/springboard/views.py
+++ b/springboard/views.py
@@ -1,10 +1,5 @@
 import os
 
-from babel import Locale
-from pycountry import languages
-
-from ast import literal_eval
-
 from elasticgit.search import SM
 
 from pyramid.view import view_config
@@ -131,14 +126,9 @@ def set_locale_cookie(self):
 
         return HTTPFound(location='/', headers=response.headers)
 
-    def get_display_name(self, locale):
-        language_code, _, country_code = locale.partition('_')
-        term_code = languages.get(bibliographic=language_code).terminology
-        return Locale.parse(term_code).language_name
-
     def get_display_languages(self):
         to_display = [
-            code for code, name in
+            code for code in
             self.featured_languages or self.available_languages[:2]
         ]
 
@@ -146,5 +136,5 @@ def get_display_languages(self):
             set(to_display) - set([self.language])),
             key=lambda tup: tup[1].lower())
         return [
-            (code, self.get_display_name(code))
+            (code)
             for code in featured_and_current]

From a4501f469b3c26a249d08597544e4acbe35ef569 Mon Sep 17 00:00:00 2001
From: nathanbegbie <nathanbegbie@gmail.com>
Date: Fri, 22 May 2015 14:37:52 +0200
Subject: [PATCH 4/9] Corrected util test

---
 springboard/tests/test_utils.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/springboard/tests/test_utils.py b/springboard/tests/test_utils.py
index de08b5f..35faa83 100644
--- a/springboard/tests/test_utils.py
+++ b/springboard/tests/test_utils.py
@@ -24,15 +24,15 @@ def test_config_list(self):
         self.assertEqual(['1', '2', '3'], config_list('1\n2\n3\n'))
         self.assertEqual([], config_list(''))
 
-    def tst_config_dict(self):
+    def test_config_dict(self):
         self.assertEqual({
             'a': '1',
             'b': '2',
             'c': '3',
-        }, 'a=1\nb=2\nc=3')
+        }, config_dict('a=1\nb=2\nc=3'))
         self.assertEqual({
-            'a': '1',
-            'b': '2',
-            'c': '3',
-        }, 'a=1\nb=2\nc=3\n')
-        self.assertEqual({}, '')
+            'foo': 'bar',
+            'gum': 'tree',
+            'elastic': 'search',
+        }, config_dict('foo=bar\ngum=tree\nelastic=search\n'))
+        self.assertEqual({}, config_dict(''))

From 7aadbe68a0e55d3da5f7e258749da9bd1b07c0e0 Mon Sep 17 00:00:00 2001
From: nathanbegbie <nathanbegbie@gmail.com>
Date: Fri, 22 May 2015 15:56:26 +0200
Subject: [PATCH 5/9] Fixed displayed languages

---
 springboard/templates/base.jinja2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/springboard/templates/base.jinja2 b/springboard/templates/base.jinja2
index 7a3c553..5e39426 100644
--- a/springboard/templates/base.jinja2
+++ b/springboard/templates/base.jinja2
@@ -14,7 +14,7 @@
     <div id="header">
         <div class="lang">
             <div>
-                {% for lang_code, name in display_languages.items() %}
+                {% for lang_code in view.get_display_languages() %}
                 <li>
                     <a href="{{'locale_matched'|route_url(language=lang_code)}}">{{lang_code|display_language_name}}</a>
                 </li>

From 6e3d155c54132c18e71c8e053880650790114701 Mon Sep 17 00:00:00 2001
From: nathanbegbie <nathanbegbie@gmail.com>
Date: Fri, 22 May 2015 17:15:32 +0200
Subject: [PATCH 6/9] Changed stored language info as just a list of locales,
 not a dict of locales and language name

---
 springboard/templates/base.jinja2          |  5 +++-
 springboard/templates/locale_change.jinja2 |  2 +-
 springboard/tests/test_language.py         | 29 ++++------------------
 springboard/views.py                       | 23 ++++-------------
 4 files changed, 15 insertions(+), 44 deletions(-)

diff --git a/springboard/templates/base.jinja2 b/springboard/templates/base.jinja2
index 5e39426..7fdecaa 100644
--- a/springboard/templates/base.jinja2
+++ b/springboard/templates/base.jinja2
@@ -14,7 +14,10 @@
     <div id="header">
         <div class="lang">
             <div>
-                {% for lang_code in view.get_display_languages() %}
+                <li>
+                    <a>{{language|display_language_name}}</a>
+                </li>
+                {% for lang_code in display_languages %}
                 <li>
                     <a href="{{'locale_matched'|route_url(language=lang_code)}}">{{lang_code|display_language_name}}</a>
                 </li>
diff --git a/springboard/templates/locale_change.jinja2 b/springboard/templates/locale_change.jinja2
index 10b67bb..a487e9b 100644
--- a/springboard/templates/locale_change.jinja2
+++ b/springboard/templates/locale_change.jinja2
@@ -3,7 +3,7 @@
 {% block content %}
 
 <ul>
-{% for lang_code, lang_name in available_languages.items() %}
+{% for lang_code in available_languages %}
 	<li>
 		<a href="{{'locale_matched'|route_url(language=lang_code) }}">{{lang_code|display_language_name}}</a>
 	</li>
diff --git a/springboard/tests/test_language.py b/springboard/tests/test_language.py
index 470ad57..b7cf36c 100644
--- a/springboard/tests/test_language.py
+++ b/springboard/tests/test_language.py
@@ -1,5 +1,4 @@
 from springboard.tests import SpringboardTestCase
-from springboard.views import SpringboardViews
 
 from pyramid import testing
 
@@ -12,13 +11,13 @@ def setUp(self):
             'unicore.repos_dir': self.working_dir,
             'unicore.content_repo_urls': self.workspace.working_dir,
             'available_languages': '\n'.join([
-                'eng_GB = English',
-                'swa_KE = Swahili',
-                'spa_ES = Spanish',
+                'eng_GB',
+                'swa_KE',
+                'spa_ES',
             ]),
             'featured_languages': '\n'.join([
-                'spa_ES = Spanish',
-                'eng_GB = English',
+                'spa_ES',
+                'eng_GB',
             ])
         }
         self.config = testing.setUp(settings=settings)
@@ -53,7 +52,6 @@ def test_locale_cookie(self):
 
     def test_change_locale_page(self):
         resp = self.app.get('/locale/change/')
-        print resp.body
         self.assertTrue(
             u'<a href="http://localhost/locale/spa_ES/">espa\xf1ol</a>'
             in resp.body.decode('utf-8'))
@@ -63,20 +61,3 @@ def test_change_locale_page(self):
         self.assertTrue(
             u'<a href="http://localhost/locale/swa_KE/">Kiswahili</a>'
             in resp.body.decode('utf-8'))
-
-    def test_locales_displayed(self):
-        view = SpringboardViews(self.mk_request())
-        langs = view.get_display_languages()
-        self.assertEqual(
-            langs, ['eng_GB', 'spa_ES'])
-
-        view = SpringboardViews(self.mk_request(locale_name='fre_FR'))
-        langs = view.get_display_languages()
-        self.assertEqual(
-            langs,
-            ['fre_FR', 'eng_GB', 'spa_ES'])
-
-        view = SpringboardViews(self.mk_request(locale_name='spa_ES'))
-        langs = view.get_display_languages()
-        self.assertEqual(
-            langs, ['spa_ES', 'eng_GB'])
diff --git a/springboard/views.py b/springboard/views.py
index c022da7..d24dae4 100644
--- a/springboard/views.py
+++ b/springboard/views.py
@@ -8,7 +8,7 @@
 from pyramid.response import Response
 
 from springboard.utils import (
-    parse_repo_name, ga_context, config_list, config_dict)
+    parse_repo_name, ga_context, config_list)
 
 from unicore.content.models import Category, Page
 from unicore.distribute.tasks import fastforward
@@ -45,12 +45,12 @@ def __init__(self, request):
         self.all_categories = SM(Category, **search_config).es(
             **self.es_settings)
         self.all_pages = SM(Page, **search_config).es(**self.es_settings)
-        self.available_languages = config_dict(
+        self.available_languages = config_list(
             self.settings.get('available_languages', ''))
-        self.featured_languages = config_dict(
+        self.featured_languages = config_list(
             self.settings.get('featured_languages', ''))
-        self.display_languages = self.available_languages.copy()
-        self.display_languages.update(self.featured_languages)
+        self.display_languages = list(
+            set(self.featured_languages) - set([self.language]))
 
     def context(self, **context):
         defaults = {
@@ -125,16 +125,3 @@ def set_locale_cookie(self):
             response.set_cookie('_LOCALE_', value=language, max_age=31536000)
 
         return HTTPFound(location='/', headers=response.headers)
-
-    def get_display_languages(self):
-        to_display = [
-            code for code in
-            self.featured_languages or self.available_languages[:2]
-        ]
-
-        featured_and_current = [self.language] + sorted(list(
-            set(to_display) - set([self.language])),
-            key=lambda tup: tup[1].lower())
-        return [
-            (code)
-            for code in featured_and_current]

From 3eedefea97090ae32953cc2b7530e46cc18b3dec Mon Sep 17 00:00:00 2001
From: nathanbegbie <nathanbegbie@gmail.com>
Date: Fri, 22 May 2015 17:31:20 +0200
Subject: [PATCH 7/9] Adhered to Simon's slight preference

---
 springboard/views.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/springboard/views.py b/springboard/views.py
index d24dae4..bee1f53 100644
--- a/springboard/views.py
+++ b/springboard/views.py
@@ -15,6 +15,8 @@
 
 from slugify import slugify
 
+ONE_YEAR = 31536000
+
 
 class SpringboardViews(object):
 
@@ -122,6 +124,6 @@ def set_locale_cookie(self):
             self.request.GET.get('language')
 
         if language:
-            response.set_cookie('_LOCALE_', value=language, max_age=31536000)
+            response.set_cookie('_LOCALE_', value=language, max_age=ONE_YEAR)
 
         return HTTPFound(location='/', headers=response.headers)

From 847129d9dcd5b9f25ab0b20e788d0e1bae0b5b66 Mon Sep 17 00:00:00 2001
From: nathanbegbie <nathanbegbie@gmail.com>
Date: Fri, 22 May 2015 17:31:33 +0200
Subject: [PATCH 8/9] Added docstrings to util functions

---
 springboard/utils.py | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/springboard/utils.py b/springboard/utils.py
index 4df6e5d..850c42e 100644
--- a/springboard/utils.py
+++ b/springboard/utils.py
@@ -42,9 +42,34 @@ def wrapper(self, *args, **kwargs):
 
 
 def config_list(data):
+    """
+    A function that takes a string of values separated by newline characters
+    and returns a list of those values
+
+    :param func context_func:
+        A function which takes one argument, a string of values separated by 
+        newline characters
+
+    :returns:
+        A list containing the values separated by newline characters, 
+        stripped of whitespace between the value and newline character
+
+    """
     return filter(None, (x.strip() for x in data.splitlines()))
 
 
 def config_dict(data):
+    """
+    A function that takes a string of pair values, indicated by '=', separated 
+    by newline characters and returns a dict of those value pairs
+
+    :param func context_func:
+        A function which takes one argument, a string of value pairs with 
+        '= between them' separated by newline characters
+
+    :returns:
+        A dict containing the value pairs separated by newline characters
+
+    """
     lines = config_list(data)
     return dict(re.split('\s*=\s*', value) for value in lines)

From bd6a6b8bb8a36693372be0087e458c2bfb20dfd7 Mon Sep 17 00:00:00 2001
From: nathanbegbie <nathanbegbie@gmail.com>
Date: Fri, 22 May 2015 17:40:48 +0200
Subject: [PATCH 9/9] Removed trailing whitespace

---
 springboard/utils.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/springboard/utils.py b/springboard/utils.py
index 850c42e..e881f59 100644
--- a/springboard/utils.py
+++ b/springboard/utils.py
@@ -47,11 +47,11 @@ def config_list(data):
     and returns a list of those values
 
     :param func context_func:
-        A function which takes one argument, a string of values separated by 
+        A function which takes one argument, a string of values separated by
         newline characters
 
     :returns:
-        A list containing the values separated by newline characters, 
+        A list containing the values separated by newline characters,
         stripped of whitespace between the value and newline character
 
     """
@@ -60,11 +60,11 @@ def config_list(data):
 
 def config_dict(data):
     """
-    A function that takes a string of pair values, indicated by '=', separated 
+    A function that takes a string of pair values, indicated by '=', separated
     by newline characters and returns a dict of those value pairs
 
     :param func context_func:
-        A function which takes one argument, a string of value pairs with 
+        A function which takes one argument, a string of value pairs with
         '= between them' separated by newline characters
 
     :returns: