Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set serial number of self-signed certificate #106

Merged
merged 1 commit into from Feb 21, 2017
Merged

Set serial number of self-signed certificate #106

merged 1 commit into from Feb 21, 2017

Conversation

@phillipp
Copy link
Contributor

@phillipp phillipp commented Nov 23, 2016

Following up on #97 the serial number must be set, too.

This pull request adds a static serial number.
@phillipp phillipp mentioned this pull request Nov 23, 2016
Closed
@unixcharles unixcharles self-assigned this Nov 24, 2016
@phillipp
Copy link
Contributor Author

@phillipp phillipp commented Feb 19, 2017

@unixcharles Is this going to be merged (and a new version released) soon? I still can't use your version but need to use my fork because TLS SNI validation doesn't work without the patch since November 2016...

@unixcharles
Copy link
Owner

@unixcharles unixcharles commented Feb 21, 2017

Sorry about that.

@unixcharles unixcharles merged commit a86fb6b into unixcharles:master Feb 21, 2017
1 check passed
@phillipp
Copy link
Contributor Author

@phillipp phillipp commented Feb 21, 2017 •
edited

Thanks bro 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unixcharles unixcharles

Assignees

@unixcharles unixcharles

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@phillipp @unixcharles