From 6dde88da581c9a70399379550381e54d007bf653 Mon Sep 17 00:00:00 2001 From: Joe Block Date: Sun, 1 Jul 2018 07:22:00 -0600 Subject: [PATCH] shellcheck fixes in git-whoami --- bin/git-whoami | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/bin/git-whoami b/bin/git-whoami index b54b3f75..f06054cd 100755 --- a/bin/git-whoami +++ b/bin/git-whoami @@ -14,13 +14,13 @@ get_email() { } get_name() { - git config user.name || getent passwd $(id -un) | cut -d : -f 5 | cut -d , -f 1 + git config user.name || getent passwd "$(id -un)" | cut -d : -f 5 | cut -d , -f 1 } -: ${GIT_AUTHOR_NAME=$(get_name)} -: ${GIT_COMMITTER_NAME=$(get_name)} -: ${GIT_AUTHOR_EMAIL=$(get_email)} -: ${GIT_COMMITTER_EMAIL=$(get_email)} +: ${GIT_AUTHOR_NAME="$(get_name)"} +: ${GIT_COMMITTER_NAME="$(get_name)"} +: ${GIT_AUTHOR_EMAIL="$(get_email)"} +: ${GIT_COMMITTER_EMAIL="$(get_email)"} author="$GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL>" commit="$GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>" @@ -30,4 +30,4 @@ if [ "$author" = "$commit" ]; then else echo "Author: $author" echo "Commit: $commit" -fi \ No newline at end of file +fi