You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The mapResultRow function's decoder extraction logic was refactored in its else branch. Previously checking field.sql directly, the code now destructures sql from field as SQL.Aliased and performs a "decoder" in sql check before accessing the decoder. This improves type alignment for aliased fields while preserving existing behavior.
Modified decoder extraction logic in mapResultRow to destructure and properly check aliased SQL fields before accessing decoder property.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
🐰 A decoder's dance, now precisely aligned,
From aliased fields, the right path we find,
With checks in place and destructuring grace,
The logic runs smoother, in its rightful place! ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small PR to fix #214
you can see an example failure on this run
Summary by CodeRabbit