Skip to content

fix: increase strength of provider types#290

Merged
danielroe merged 4 commits intomainfrom
chore/clean-code-prepare
Nov 21, 2025
Merged

fix: increase strength of provider types#290
danielroe merged 4 commits intomainfrom
chore/clean-code-prepare

Conversation

@florian-lefebvre
Copy link
Collaborator

@florian-lefebvre florian-lefebvre commented Nov 20, 2025

To make #287 and #288 diffs smaller and easier to review:

  • Improves some types
  • Update unifont methods to directly be returned, to allow infering types (useful for generics)

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.91%. Comparing base (dc0d37a) to head (5a7626e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   98.90%   98.91%           
=======================================
  Files          11       11           
  Lines         458      460    +2     
  Branches      112      113    +1     
=======================================
+ Hits          453      455    +2     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@florian-lefebvre florian-lefebvre changed the title chore: clean code feat: improve types Nov 20, 2025
@danielroe danielroe changed the title feat: improve types fix: increase strength of provider types Nov 21, 2025
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danielroe danielroe merged commit 92ceb7a into main Nov 21, 2025
9 checks passed
@danielroe danielroe deleted the chore/clean-code-prepare branch November 21, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants