Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): name used import on duplicate on warning #271

Merged
merged 1 commit into from
Sep 6, 2023
Merged

feat(utils): name used import on duplicate on warning #271

merged 1 commit into from
Sep 6, 2023

Conversation

dargmuesli
Copy link
Contributor

πŸ”— Linked issue

n/a

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This should improve DX as it allows to quickly identify a duplicated import.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

This should improve DX as it allows to quickly identify a duplicated import.
@antfu antfu changed the title feat(utils): name used import on duplicate feat(utils): name used import on duplicate on warning Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #271 (47c6a21) into main (5ad2b37) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          57       57           
  Lines        1481     1481           
  Branches      302      302           
=======================================
  Hits         1446     1446           
  Misses         35       35           
Files Changed Coverage Ξ”
src/utils.ts 97.76% <100.00%> (ΓΈ)

@antfu antfu merged commit 28cf011 into unjs:main Sep 6, 2023
5 checks passed
@dargmuesli dargmuesli deleted the feat/dedupe/warn-both branch September 6, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants