New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Tier 5 Public Bath #2698

Closed
AndyMender opened this Issue May 31, 2017 · 36 comments

Comments

Projects
None yet
4 participants
@AndyMender
Member

AndyMender commented May 31, 2017

I would like to contribute to the graphics aspect of Unknown Horizons as well. Per discussions with @LinuxDonald, one of the new, yet not implemented tier 4 buildings is a bath house. I have experience with 3D modeling in Blender, but none insofar regarding Unknown Horizons models. Therefore, I would need some initial "hand holding" and feedback from @janexx.

This might serve as an initial inspiration: https://vignette2.wikia.nocookie.net/anno1404guide/images/9/9f/Bathhouse.png/revision/latest/scale-to-width-down/250?cb=20091118174520 . I am open to any and all feedback (style fitting other tier 4 buildings? general time period and culture?).

@AndyMender AndyMender self-assigned this May 31, 2017

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 3, 2017

Member

An update on my Blender work:
bathhouse0001
Due to a slight misalignment with the model, the right set of windows would require manual fixing. Finally, the whole thing needs to be UV mapped and textured. @janexx, what are you thoughts? :)

Member

AndyMender commented Jun 3, 2017

An update on my Blender work:
bathhouse0001
Due to a slight misalignment with the model, the right set of windows would require manual fixing. Finally, the whole thing needs to be UV mapped and textured. @janexx, what are you thoughts? :)

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 4, 2017

Member

Nice @AndyMender ! I just find it a bit unpractical that people have to climb up in the swimming pool. Maybe better make a kind of whole in the ground, maybe with a small stair? You could also add some seats. Just my ideas... :)

Member

janexx commented Jun 4, 2017

Nice @AndyMender ! I just find it a bit unpractical that people have to climb up in the swimming pool. Maybe better make a kind of whole in the ground, maybe with a small stair? You could also add some seats. Just my ideas... :)

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 4, 2017

Member

Yes, this of course makes a lot more sense. I will try to make a square pool in the middle with some stairs. Would look a lot better, I'm sure!

EDIT: I removed the round "bowl" and created a central floor pool with a layer of water. There is a ledge to the right, but since the water has no transparency on the material, one cannot see it in a raw render.
bathhouse0001

I think it's time for the materials and texturing :).

Member

AndyMender commented Jun 4, 2017

Yes, this of course makes a lot more sense. I will try to make a square pool in the middle with some stairs. Would look a lot better, I'm sure!

EDIT: I removed the round "bowl" and created a central floor pool with a layer of water. There is a ledge to the right, but since the water has no transparency on the material, one cannot see it in a raw render.
bathhouse0001

I think it's time for the materials and texturing :).

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 4, 2017

Member

Good! Looks better now. I would make the stairs over the whole width of the pool. I am looking forward to see the it with textures! I recommend to make preview renderings in the final image size. :)

Member

janexx commented Jun 4, 2017

Good! Looks better now. I would make the stairs over the whole width of the pool. I am looking forward to see the it with textures! I recommend to make preview renderings in the final image size. :)

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 4, 2017

Member

I'll try to UV-map and texture/shade the thing and we'll see what still needs to be done. @janexx do you perhaps have custom texture sets for roof tiles and stone brick walls, used for other buildings in Unknown Horizons?

bathhouse0001

It's starting to look like something finally as I now understand how the shaders work in Blender. I still need to create the roof tiles and I can hand it over to @janexx for final rendering and projections :).

EDIT: Mostly done. Can be sent for generating projections.

Member

AndyMender commented Jun 4, 2017

I'll try to UV-map and texture/shade the thing and we'll see what still needs to be done. @janexx do you perhaps have custom texture sets for roof tiles and stone brick walls, used for other buildings in Unknown Horizons?

bathhouse0001

It's starting to look like something finally as I now understand how the shaders work in Blender. I still need to create the roof tiles and I can hand it over to @janexx for final rendering and projections :).

EDIT: Mostly done. Can be sent for generating projections.

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jun 5, 2017

Member

Maybe add some flowers or something like decoration?

Member

LinuxDonald commented Jun 5, 2017

Maybe add some flowers or something like decoration?

@squiddy

This comment has been minimized.

Show comment
Hide comment
@squiddy

squiddy Jun 5, 2017

Member

Also, the walls/roof should probably look like it was made from actual single stones / tiles. Right now, it's just a texture on top. Isn't there some magic like normal maps / bumpmapping to improve the visuals here?

Member

squiddy commented Jun 5, 2017

Also, the walls/roof should probably look like it was made from actual single stones / tiles. Right now, it's just a texture on top. Isn't there some magic like normal maps / bumpmapping to improve the visuals here?

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 5, 2017

Member

There is. The texture lacks a normal map, but that can be added and fed to the right shader. Alternatively, I could create the tiles in Blender entirely (using the current textures as base). This takes a bit more time for rendering afterwards, of course.

For the walls I was thinking of adding a volume shader so that the bricks get some depth and a real 3D feel.

In-game you won't see a difference, though, because our models are severely pixelated anyhow.

It might be worth working on the foundation material a bit more, methinks. Like adding a pattern around the pool, etc.

Member

AndyMender commented Jun 5, 2017

There is. The texture lacks a normal map, but that can be added and fed to the right shader. Alternatively, I could create the tiles in Blender entirely (using the current textures as base). This takes a bit more time for rendering afterwards, of course.

For the walls I was thinking of adding a volume shader so that the bricks get some depth and a real 3D feel.

In-game you won't see a difference, though, because our models are severely pixelated anyhow.

It might be worth working on the foundation material a bit more, methinks. Like adding a pattern around the pool, etc.

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 5, 2017

Member

@AndyMender We have already roofs. You can use and mybe modify them (copy or via append). Just look at other models with roofs, e.g. other habitant houses. For the bricks, you can try just a bump map or model the bricks yourself. Or you can use some of the stone wall:
https://github.com/unknown-horizons/gfx/blob/master/janexx/buildings/wall/wall_stone/wall_stone_BLENDER-v278.blend
Also look at the small rendered image, not just at the 960px × 540px image.

Member

janexx commented Jun 5, 2017

@AndyMender We have already roofs. You can use and mybe modify them (copy or via append). Just look at other models with roofs, e.g. other habitant houses. For the bricks, you can try just a bump map or model the bricks yourself. Or you can use some of the stone wall:
https://github.com/unknown-horizons/gfx/blob/master/janexx/buildings/wall/wall_stone/wall_stone_BLENDER-v278.blend
Also look at the small rendered image, not just at the 960px × 540px image.

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 5, 2017

Member

Thank you @janexx . I will do that then :).

Member

AndyMender commented Jun 5, 2017

Thank you @janexx . I will do that then :).

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 8, 2017

Member

Update: new version with hand-crafted roof tiles and bricks.
bathhouse0001

Member

AndyMender commented Jun 8, 2017

Update: new version with hand-crafted roof tiles and bricks.
bathhouse0001

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jun 9, 2017

Member

Maybe the roof should be in an other color? what do you think @janexx ?
And still no ground texture.
The floor should be gone texture maybe instand of wood.

Member

LinuxDonald commented Jun 9, 2017

Maybe the roof should be in an other color? what do you think @janexx ?
And still no ground texture.
The floor should be gone texture maybe instand of wood.

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 9, 2017

Member

The roof is better now. The single roof tiles just seem a bit small? I don't know how it looks in 128x128 pixel size (or what tile size should it have @LinuxDonald ?) Please give me also the render image in final size. :)
But I also would say, that the roof and the walls should have at least a bit different colour. The whole ground could maybe get a stone texture? I guess the ground texture inside the house (now the wood) won't be visible at the end. Looks a bit modern. :) When we use wood for building before, we modeled them because elswise you see just a brown plane.

Member

janexx commented Jun 9, 2017

The roof is better now. The single roof tiles just seem a bit small? I don't know how it looks in 128x128 pixel size (or what tile size should it have @LinuxDonald ?) Please give me also the render image in final size. :)
But I also would say, that the roof and the walls should have at least a bit different colour. The whole ground could maybe get a stone texture? I guess the ground texture inside the house (now the wood) won't be visible at the end. Looks a bit modern. :) When we use wood for building before, we modeled them because elswise you see just a brown plane.

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jun 9, 2017

Member

Yeah @janexx is right @AndyMender please do what jana have written :)
Size should be 2x2 i think?

Member

LinuxDonald commented Jun 9, 2017

Yeah @janexx is right @AndyMender please do what jana have written :)
Size should be 2x2 i think?

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 9, 2017

Member

Ehm I just want to add that are not orders, just ideas and hints. :)

Member

janexx commented Jun 9, 2017

Ehm I just want to add that are not orders, just ideas and hints. :)

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jun 9, 2017

Member

@janexx you are the chief grafic artist :P And i like your ideas you make wonderful grafics :)

Member

LinuxDonald commented Jun 9, 2017

@janexx you are the chief grafic artist :P And i like your ideas you make wonderful grafics :)

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 12, 2017

Member

Yes, now that I look at it again, the roof should definitely have a different color (maybe some brighter red?). I will remove the wooden floor texture, too. Finally, I was thinking of adding some greyish plaster in-between the bricks. Will this be visible in the final render?

No ground texture was planned, but if the building is supposed to be a 2x2 and not 2x3, then I might want to add some grass or something similar. Frankly, I didn't look at the dimensions properly yet :(.

Member

AndyMender commented Jun 12, 2017

Yes, now that I look at it again, the roof should definitely have a different color (maybe some brighter red?). I will remove the wooden floor texture, too. Finally, I was thinking of adding some greyish plaster in-between the bricks. Will this be visible in the final render?

No ground texture was planned, but if the building is supposed to be a 2x2 and not 2x3, then I might want to add some grass or something similar. Frankly, I didn't look at the dimensions properly yet :(.

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 12, 2017

Member

Will this be visible in the final render?

Try it out!

@LinuxDonald Is also 2x3 possible? I think that would look good.

Member

janexx commented Jun 12, 2017

Will this be visible in the final render?

Try it out!

@LinuxDonald Is also 2x3 possible? I think that would look good.

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jun 12, 2017

Member

Yeah we could make it. But we must than look too about the offset it it not brings new problems.

Member

LinuxDonald commented Jun 12, 2017

Yeah we could make it. But we must than look too about the offset it it not brings new problems.

@AndyMender AndyMender referenced this issue Jun 13, 2017

Merged

Public bath #2714

@AndyMender AndyMender changed the title from Create Tier 4 Bath House to Create Tier 5 Public Bath Jun 13, 2017

@LinuxDonald LinuxDonald added this to the 2017.3 milestone Jun 17, 2017

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 17, 2017

Member

I decided not to add a grey plaster in-between the bricks since it would not be visible anyway. The building is mostly finished and if possible, I would like to get back to working on the Python code and leave generating the renders to @janexx.
bathhouse0001
To that end, how do I upload the .blend since I don't have access to the gfx repository?

Member

AndyMender commented Jun 17, 2017

I decided not to add a grey plaster in-between the bricks since it would not be visible anyway. The building is mostly finished and if possible, I would like to get back to working on the Python code and leave generating the renders to @janexx.
bathhouse0001
To that end, how do I upload the .blend since I don't have access to the gfx repository?

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jun 17, 2017

Member

You have now the needed rights for uploading @AndyMender maybe @janexx could do some final work on the bath?

Member

LinuxDonald commented Jun 17, 2017

You have now the needed rights for uploading @AndyMender maybe @janexx could do some final work on the bath?

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 17, 2017

Member

@AndyMender Ok, I can do the rendering. I thought you render it at least once in the final render size so that we see how it will look like. But OK, I can do that and then post it here. Is it OK for you when I do some final work then or do you want to do that yourself then?
Can you add a new folder in the gfx repository with your name and upload the blend file there?

Member

janexx commented Jun 17, 2017

@AndyMender Ok, I can do the rendering. I thought you render it at least once in the final render size so that we see how it will look like. But OK, I can do that and then post it here. Is it OK for you when I do some final work then or do you want to do that yourself then?
Can you add a new folder in the gfx repository with your name and upload the blend file there?

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 17, 2017

Member

@janexx , yes, I am perfectly fine with you doing some extra adjustments if you feel they're needed :). I don't have much experience with rendering, unfortunately. The added .blend file is here: unknown-horizons/gfx@1ce8b20

Member

AndyMender commented Jun 17, 2017

@janexx , yes, I am perfectly fine with you doing some extra adjustments if you feel they're needed :). I don't have much experience with rendering, unfortunately. The added .blend file is here: unknown-horizons/gfx@1ce8b20

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 17, 2017

Member

@AndyMender Thanks, I have it now. I adapted it so that it fits into our default szene and rendered it:
000
000
In the default UH camera view now one almost can't see any water. I would propose to add more and bigger entrances, maybe more roundly.

Member

janexx commented Jun 17, 2017

@AndyMender Thanks, I have it now. I adapted it so that it fits into our default szene and rendered it:
000
000
In the default UH camera view now one almost can't see any water. I would propose to add more and bigger entrances, maybe more roundly.

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 17, 2017

Member

Maybe we should make the side entrances to the pool go through the external walls or open up part of the front with Roman-style columns?

Member

AndyMender commented Jun 17, 2017

Maybe we should make the side entrances to the pool go through the external walls or open up part of the front with Roman-style columns?

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 17, 2017

Member

Yes, that sounds nice! I haven't even noticed that there are side entrances... :) Do you want to model that? I can do that too if you rather want to code again, but I don't want to take away your model. I could upload the current blend file with the proper settings (camera, light).

Member

janexx commented Jun 17, 2017

Yes, that sounds nice! I haven't even noticed that there are side entrances... :) Do you want to model that? I can do that too if you rather want to code again, but I don't want to take away your model. I could upload the current blend file with the proper settings (camera, light).

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 17, 2017

Member

Also the render script is in, you would just have to press alt+P in the text editor view.

Member

janexx commented Jun 17, 2017

Also the render script is in, you would just have to press alt+P in the text editor view.

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 17, 2017

Member

If you could upload the improved .blend. I will take care of the side entrances :). Thanks a lot for providing the script!

Member

AndyMender commented Jun 17, 2017

If you could upload the improved .blend. I will take care of the side entrances :). Thanks a lot for providing the script!

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 18, 2017

Member

@janexx , I added the extra doorways as we discussed: unknown-horizons/gfx@c366e31
Unfortunately, even with your script the renders don't show anything for me, because I have some nVidia related issues with the Cycles Render engine as of late.

Member

AndyMender commented Jun 18, 2017

@janexx , I added the extra doorways as we discussed: unknown-horizons/gfx@c366e31
Unfortunately, even with your script the renders don't show anything for me, because I have some nVidia related issues with the Cycles Render engine as of late.

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 18, 2017

Member

@AndyMender Hm OK. I would say, its not bad, but there is still some room for improvement.. :)
000
000
E.g. Colors, nicer/round entrances and windows, columns... :D

Member

janexx commented Jun 18, 2017

@AndyMender Hm OK. I would say, its not bad, but there is still some room for improvement.. :)
000
000
E.g. Colors, nicer/round entrances and windows, columns... :D

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jun 18, 2017

Member

Maybe Glas walls?

Member

LinuxDonald commented Jun 18, 2017

Maybe Glas walls?

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 18, 2017

Member

bathhouse0001
With columns. Added to the unknown-horizons/gfx repository.

Member

AndyMender commented Jun 18, 2017

bathhouse0001
With columns. Added to the unknown-horizons/gfx repository.

@janexx

This comment has been minimized.

Show comment
Hide comment
@janexx

janexx Jun 19, 2017

Member

@AndyMender That looks nice with the columns. Now the nice water is visible. I like that water with the white rings. Only the red brick I don't like so much and the windows. Now with the grey columns, the red bricks look even weirder for me. I just made it now like I would like it and uploaded the file. The windows are now added a bit quick and dirty... Maybe you can do something with it.
By the way with windows now my script also fails. :/

Here a picture:
bathchanges

Member

janexx commented Jun 19, 2017

@AndyMender That looks nice with the columns. Now the nice water is visible. I like that water with the white rings. Only the red brick I don't like so much and the windows. Now with the grey columns, the red bricks look even weirder for me. I just made it now like I would like it and uploaded the file. The windows are now added a bit quick and dirty... Maybe you can do something with it.
By the way with windows now my script also fails. :/

Here a picture:
bathchanges

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jun 19, 2017

Member

Good work :-) I like it

Member

LinuxDonald commented Jun 19, 2017

Good work :-) I like it

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 20, 2017

Member

I really like the grey-yellow walls and I feel the windows look alright :). Perhaps the remaining doorway could get a similar treatment? Other than that, it's a great improvement over the initial model already.

Member

AndyMender commented Jun 20, 2017

I really like the grey-yellow walls and I feel the windows look alright :). Perhaps the remaining doorway could get a similar treatment? Other than that, it's a great improvement over the initial model already.

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jan 21, 2018

Member

Its already done.

Member

LinuxDonald commented Jan 21, 2018

Its already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment