New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't offer route configuration with only one settlement #2721

Closed
squiddy opened this Issue Jun 18, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@squiddy
Member

squiddy commented Jun 18, 2017

If the player only has one settlement, it is still possible to open the route configuration menu, only to find out that one has to select at least two settlements.

Shouldn't we just disable this feature until two settlements were build?

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 18, 2017

Member

As in, provide a pop-up widget informing the player that 2+ settlements are required to configure a route, at the time the traderoute config menu is being generated?

To be more specific:

  1. player clicks on the traderoute menu icon.
  2. the responsible class checks whether the player has 2 or more settlements early on (this is anyhow used by the traderoute menu)
  3. if the check fails (player has 1 settlement), the traderoute menu is instantly destroyed.

Would that be alright?

Member

AndyMender commented Jun 18, 2017

As in, provide a pop-up widget informing the player that 2+ settlements are required to configure a route, at the time the traderoute config menu is being generated?

To be more specific:

  1. player clicks on the traderoute menu icon.
  2. the responsible class checks whether the player has 2 or more settlements early on (this is anyhow used by the traderoute menu)
  3. if the check fails (player has 1 settlement), the traderoute menu is instantly destroyed.

Would that be alright?

@MasterofJOKers

This comment has been minimized.

Show comment
Hide comment
@MasterofJOKers

MasterofJOKers Jun 18, 2017

Contributor

One could grey-out the "traderoute menu icon" and provide information why in a mouseover. No need to let the user think, he/she can click it.

Contributor

MasterofJOKers commented Jun 18, 2017

One could grey-out the "traderoute menu icon" and provide information why in a mouseover. No need to let the user think, he/she can click it.

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jun 18, 2017

Member

I think that's an even better solution, true :).

Member

AndyMender commented Jun 18, 2017

I think that's an even better solution, true :).

@squiddy

This comment has been minimized.

Show comment
Hide comment
@squiddy

squiddy Jun 19, 2017

Member

Yeah, greying it out was what I was thinking of as well.

Member

squiddy commented Jun 19, 2017

Yeah, greying it out was what I was thinking of as well.

@yhoyhoj

This comment has been minimized.

Show comment
Hide comment
@yhoyhoj

yhoyhoj Jun 18, 2018

I'd like to try this.
I have already found the files to modify but I am not sure of the desired behaviour.

Considering the player can also trade with other players or IA, it should check the total number of warehouses on the map. Should it also check if the warehouses are allowed in a route (ie. owned by an ally) ?
And given that there are multiple reasons to grey that button out, would a tooltip saying something like : "There are no available destination for a trade route yet" be enough ?

yhoyhoj commented Jun 18, 2018

I'd like to try this.
I have already found the files to modify but I am not sure of the desired behaviour.

Considering the player can also trade with other players or IA, it should check the total number of warehouses on the map. Should it also check if the warehouses are allowed in a route (ie. owned by an ally) ?
And given that there are multiple reasons to grey that button out, would a tooltip saying something like : "There are no available destination for a trade route yet" be enough ?

@MasterofJOKers

This comment has been minimized.

Show comment
Hide comment
@MasterofJOKers

MasterofJOKers Jun 19, 2018

Contributor

Yes, please also check for allied warehouses.
Yes, that tooltip-text should be enough.

Contributor

MasterofJOKers commented Jun 19, 2018

Yes, please also check for allied warehouses.
Yes, that tooltip-text should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment