New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naval combat system #2733

Open
AndyMender opened this Issue Jul 21, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@AndyMender
Member

AndyMender commented Jul 21, 2017

In reference to issue #1258, our naval combat system seems completely broken. While previously the issue was the inability of frigates to aim cannons, currently frigates cannot even be produced. A short list of items to tackle below:

  • Reinstate/fix frigate production.

  • Fix FightingShip's rotation & aiming system.

  • Write missing ship tests.

  • Improve naval combat.

A corresponding branch fix-combat-system has been created to this end. Feedback from @LinuxDonald on game design decisions would be greatly appreciated :).

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald Jul 22, 2017

Member

For the first the combat system needs to get working again. After that we will see what changes are needed on it.

Member

LinuxDonald commented Jul 22, 2017

For the first the combat system needs to get working again. After that we will see what changes are needed on it.

@AndyMender

This comment has been minimized.

Show comment
Hide comment
@AndyMender

AndyMender Jul 22, 2017

Member

Apparently, I might have been in the wrong and frigate production actually works. Noted in first post.

EDIT: Naval combat works as tested several times by dueling the pirate AI on the tutorial map. It might be worth writing a game test that would simulate such a battle.

Member

AndyMender commented Jul 22, 2017

Apparently, I might have been in the wrong and frigate production actually works. Noted in first post.

EDIT: Naval combat works as tested several times by dueling the pirate AI on the tutorial map. It might be worth writing a game test that would simulate such a battle.

@AndyMender AndyMender changed the title from Naval combat system is broken to Improve naval combat system Jul 23, 2017

@AndyMender AndyMender removed the B-bug label Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment