New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update check crashes game #2754

Closed
Ismoez opened this Issue Nov 13, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Ismoez

Ismoez commented Nov 13, 2017

If i open the game it crashes after a couple of seconds:

The problem is in unknown-horizons/horizons/util/checkupdates.py

line 93:
text = T("There is a more recent release of Unknown Horizons ({new_version}) " "than the one you are currently using ({old_version}).").format( new_version=info.version, old_version=VERSION.RELEASE_VERSION)

the content of info.version is a html
i uploaded it as a html info_version.html here the link:
http://ranbu.org/unknown_horizons/info_version.html

as a workaround im just setting a random string for new_version:
text = T("There is a more recent release of Unknown Horizons ({new_version}) " "than the one you are currently using ({old_version}).").format( new_version="a", old_version=VERSION.RELEASE_VERSION)

@jmdejong

This comment has been minimized.

Show comment
Hide comment
@jmdejong

jmdejong May 6, 2018

Contributor

The update check code has been changed in commit 7677635
This should be fixed in the current development version (the current code on github

Contributor

jmdejong commented May 6, 2018

The update check code has been changed in commit 7677635
This should be fixed in the current development version (the current code on github

@LinuxDonald

This comment has been minimized.

Show comment
Hide comment
@LinuxDonald

LinuxDonald May 6, 2018

Member

yeah thats an bug of the last release version. We will release an new fixed version this Summer.

Member

LinuxDonald commented May 6, 2018

yeah thats an bug of the last release version. We will release an new fixed version this Summer.

@LinuxDonald LinuxDonald closed this May 6, 2018

@LinuxDonald LinuxDonald added this to the 2018.1 milestone May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment