New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-firing of `keyPressed` events in `IngameKeyListener` #2758

Closed
FedericoStra opened this Issue Nov 24, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@FedericoStra
Contributor

FedericoStra commented Nov 24, 2017

The IngameKeyListener seems to double fire keyPressed events.
The net effect is that it is impossible to use hotkeys such as B
because the dropdown construction menu just flashes for an instant
and then closes back down immediately.

I suspect this is a deeper issue inside fifengine, but I am not
familiar with that so here I offer a quick fix to avoid the problem.

Here is a viable solution that works well for me: #2757.

Of course, if you know how the better solve the issue inside of fifengine,
then just do it and discard the proposed pull request!

@FedericoStra

This comment has been minimized.

Show comment
Hide comment
@FedericoStra

FedericoStra Nov 24, 2017

Contributor

Forgot to mention, my setup is:

  • Ubuntu 14.04
  • Linux 3.13.0-133-generic
  • fife 0.4.1+build.6d7e692 (installed from source)
  • fifechan 0.2.0 (installed from source)
Contributor

FedericoStra commented Nov 24, 2017

Forgot to mention, my setup is:

  • Ubuntu 14.04
  • Linux 3.13.0-133-generic
  • fife 0.4.1+build.6d7e692 (installed from source)
  • fifechan 0.2.0 (installed from source)

@LinuxDonald LinuxDonald added this to the 2018.1 milestone Jul 20, 2018

@LinuxDonald LinuxDonald added the B-bug label Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment