New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fife in travis #2841

Closed
jmdejong opened this Issue May 18, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@jmdejong
Contributor

jmdejong commented May 18, 2018

Currently gui tests fail with the message AttributeError: 'SelectionTool' object has no attribute 'setGlobalListener'.
This makes sense since the method IMouseListener.setGlobalListener was added in a recent change to the development version of Fife.
Can we update Fife in travis so that it includes this method?
Alternatively we could try to make a dummy implementation of that method.

@LinuxDonald

This comment has been minimized.

Member

LinuxDonald commented May 18, 2018

@MasterofJOKers could you maybe update the fife packages for travis please?

@MarkusHackspacher

This comment has been minimized.

Contributor

MarkusHackspacher commented Sep 14, 2018

See #2872
I use the new fife paket 0.4.1+git20180904-2 from debian sid.

@LinuxDonald

This comment has been minimized.

Member

LinuxDonald commented Sep 14, 2018

Please fix the typo than I can merge it.

@MarkusHackspacher

This comment has been minimized.

Contributor

MarkusHackspacher commented Sep 15, 2018

@LinuxDonald : What you mean with fix the typo?

@LinuxDonald

This comment has been minimized.

Member

LinuxDonald commented Sep 15, 2018

You have on one line python3.56 ;)

@LinuxDonald

This comment has been minimized.

Member

LinuxDonald commented Sep 15, 2018

Fixed with: #2872

@LinuxDonald LinuxDonald added this to the 2018.1 milestone Sep 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment