New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on quit #2897

Open
jakoch opened this Issue Jan 26, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@jakoch
Copy link

jakoch commented Jan 26, 2019

When quitting the game (on Windows), the game crashes.

Starting Unknown Horizons
output will be written to logfile "unknownhorizons-DATETIME.log"
Logging to b'C:\Users\koch\Documents\My Games\unknown-horizons\log\unknown-horizons-2019-01-26_17-04-04.log' and D:\Unknown-Horizons\unknown-horizons\fife.log
Danke, dass Ihr Unknown Horizons spielt!Traceback (most recent call last):
File "run_uh.py", line 381, in
main()
File "run_uh.py", line 127, in main
print(T('Thank you for using Unknown Horizons!'))
File "run_uh.py", line 255, in write
logfile.write(line)
ValueError: I/O operation on closed file.

Error in sys.excepthook:
Traceback (most recent call last):
File "run_uh.py", line 183, in excepthook
print('\n', T('Unknown Horizons has crashed.'), '\n')
File "run_uh.py", line 255, in write
logfile.write(line)
ValueError: I/O operation on closed file.

Original exception was:
Traceback (most recent call last):
File "run_uh.py", line 381, in
main()
File "run_uh.py", line 127, in main
print(T('Thank you for using Unknown Horizons!'))
File "run_uh.py", line 255, in write
logfile.write(line)
ValueError: I/O operation on closed file.
Exception ignored in: <main.setup_debugging..StdOutDuplicator object at 0x04401470>
Traceback (most recent call last):
File "run_uh.py", line 258, in flush
logfile.flush()
ValueError: I/O operation on closed file.

@jmdejong

This comment has been minimized.

Copy link
Contributor

jmdejong commented Jan 31, 2019

I think this is not just windows. I've had this a few times on linux as well

@jakoch jakoch added the O-Linux label Jan 31, 2019

@LinuxDonald

This comment has been minimized.

Copy link
Member

LinuxDonald commented Jan 31, 2019

Is this bug fixed? We could do than an hot fix release.

@jmdejong

This comment has been minimized.

Copy link
Contributor

jmdejong commented Jan 31, 2019

I haven't been able to reproduce it right now and I don't remember the circumstances in which I had it earlier.
I think it would be easy to fix though if we'd move the "Thank you" print before the closing of the log file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment