New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for auto muxing captions into video files #293

Merged
merged 29 commits into from Apr 7, 2016

Conversation

Projects
None yet
2 participants
@mfairchild365
Copy link
Contributor

mfairchild365 commented Apr 7, 2016

No description provided.

$result = $muxer->mux();
var_dump($result);
//TODO integrate, add tests and plan deployment.

This comment has been minimized.

@kabel

kabel Apr 7, 2016

Contributor

👎

This comment has been minimized.

@mfairchild365

mfairchild365 Apr 7, 2016

Contributor

👍

*
* @var bool
*/
public static $auto_mux = true;

This comment has been minimized.

@kabel

kabel Apr 7, 2016

Contributor

Oh man, are we still using public static's for config. :(

This comment has been minimized.

@mfairchild365

mfairchild365 Apr 7, 2016

Contributor

Seems out of scope of this PR to change the config style.

This comment has been minimized.

@kabel

kabel Apr 7, 2016

Contributor

You are correct. Just an observation.

list($width, $height) = $this->getVideoDimensions();
$result = $this->getVideoDimensions();
if (!$result) {
$result = array(0=>null, 1=>null);

This comment has been minimized.

@kabel

kabel Apr 7, 2016

Contributor

Are the keys necessary? Let's shoot for short array syntax.

This comment has been minimized.

@kabel

kabel Apr 7, 2016

Contributor

Seems like the ?: operator would simplify this.

This comment has been minimized.

@mfairchild365

mfairchild365 Apr 7, 2016

Contributor

fair enough

@@ -0,0 +1,2 @@
<?php
class UNL_MediaHub_MuxerException extends RunTimeException implements UNL_MediaHub_Exception {}

This comment has been minimized.

@kabel

kabel Apr 7, 2016

Contributor

👎 for newline and braces on own lines (PSR-2).

@kabel kabel merged commit 3fdd8fe into unl:4.0_template Apr 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment