More wdn-hero updates #1003
Merged
More wdn-hero updates #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same issue as #04575910 display: block removes unwanted space below the video, visibile between 768–960px
A height declaration is needed to use object-fit on child elements.
Define explicit hero height for browsers that don't support object-fit in hopes of avoiding images or videos not filling the allotted vertical space.
'objectfit' is the [recommended usage](http://new.modernizr.com/download/#setclasses&q=object fit) by Modernizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, I'll likely have more updates on the way.