More wdn-hero updates #1003

Merged
merged 8 commits into from Jun 7, 2016

Conversation

Projects
None yet
2 participants
@skoolbus39
Member

skoolbus39 commented Jun 7, 2016

  • Changed video to display: block (Same issue as #04575910)
  • Added object-fit support for hero videos and images

FYI, I'll likely have more updates on the way.

skoolbus39 added some commits May 23, 2016

.wdn-hero-video video display: block
Same issue as #04575910

display: block removes unwanted space below the video, visibile between 768–960px
Apply height to hero band at bp768
A height declaration is needed to use object-fit on child elements.
Move fluid hero height to object-fit conditional
Define explicit hero height for browsers that don't support object-fit in hopes of avoiding images or videos not filling the allotted vertical space.

@kabel kabel merged commit cbe7fdd into unl:develop Jun 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment