Add Big Ten Academic Alliance link and logo to global footer #1008

Merged
merged 22 commits into from Jul 1, 2016

Conversation

Projects
None yet
2 participants
@skoolbus39
Member

skoolbus39 commented Jul 1, 2016

CIC has been replaced by the Big Ten Academic Alliance. The Big Ten Conference and CIC links and logos have been removed and replaced by the new Big Ten Academic Alliance link and logo.

skoolbus39 added some commits Jun 30, 2016

Remove margin-bottom from logos
UNL & BTAA logos will always be side-by-side. Margin-bottom will be moved/added to .wdn-footer-logos for mobile instead of applying the margin to the individual logos.
Remove unnecessary grid-set and columns
Moving UNL and Big Ten Academic Alliance wordmarks into a flexbox-based lockup that will better scale with browser width.
Wrap links with <div>s for flexbox aspect ratios
Using padding to maintain intrinsic aspect ratios on flex items doesn't work in Firefox and Edge per the spec's recommendation: http://stackoverflow.com/questions/23717953/padding-bottom-top-in-flexbox-layout

The links are now wrapped in <div>s which allow the children links to maintain intrinsic aspect ratios, thus showing the background-image logos.
Add flexbox to footer logos
The grid set has been removed from the markup. The logos will instead use flexbox to maintain a scalable, proportional lockup.
Remove anchor element from class
The anchor element is not needed here. Height and width do not affect the links.
Add margin-bottom to footer logos under 640 wide
This will create vertical space between the footer logos and the WDN/QA/copyright statement.
Single max-width for footer logos
By using flexbox instead of the grid set, only a single max-width is required for the footer logos.
Apply width to logo containers
The grid set and columns have been removed from the markup, replaced by flexbox in the CSS. Widths are now applied to the flex elements: #unl_wordmark and #b1g_wordmark.
Remove max-width from #unl_wordmark
Max-width is now applied to .wdn-footer-logos (#unl_wordmark and #b1g_wordmark will scale proportionally), so the #unl_wordmark is no longer necessary.
Remove margin-top from #b1g_wordmark
The footer logos are now side-by-side at all widths. The margin-top is no longer necessary.
Move footer logo styles to children elements
The .wdn-footer-logo links are now children of the flex elements (identified by #unl_wordmark and #b1g_wordmark). Their styles have been moved accordingly.
@skoolbus39

This comment has been minimized.

Show comment
Hide comment
@skoolbus39

skoolbus39 Jul 1, 2016

Member

I've tested in Chrome, Safari, and Firefox, but have not tested in Edge or IE. My 'iimdee' address is no longer functional out of the office so Browserstack isn't an option. If someone has access to either or both browsers and can test, please do. Thanks.

Member

skoolbus39 commented Jul 1, 2016

I've tested in Chrome, Safari, and Firefox, but have not tested in Edge or IE. My 'iimdee' address is no longer functional out of the office so Browserstack isn't an option. If someone has access to either or both browsers and can test, please do. Thanks.

@kabel

This comment has been minimized.

Show comment
Hide comment
@skoolbus39

This comment has been minimized.

Show comment
Hide comment
@skoolbus39

skoolbus39 Jul 1, 2016

Member

What?!?!?!

Member

skoolbus39 commented Jul 1, 2016

What?!?!?!

@kabel kabel merged commit d3e0ec9 into unl:develop Jul 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment