Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
WIP: A11y improvements #1010
NOTE: this PR is under development, do not merge yet. I've created this PR as a place to discuss and coordinate.
This aims to fix the following issues:
In a future release: Improve tab order of these controls as well. Because they are moved around with css at different widths, tab order is sometimes incorrect.
@kabel I think this is ready to be reviewed (I know its a lot).
I'm a little worried about the potential case where some sites might not have the newest version of the includes, but DO have the newest assets. I've added some CSS to hide the old labels, but some of the functionality won't work until the includes are updated. Would it be worth it to go a step further and make sure that the functionality works even if the includes are not updated? I'm guessing not.
Do you think this is okay to roll out?