New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print style cleanup and restore logo styles #1018

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@skoolbus39
Member

skoolbus39 commented Sep 26, 2016

Fixes #1015

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Sep 27, 2016

Contributor

Revert back to using a logo url this will cause problems on the first print when the image is not cached. The print will not include the logo until the logo is loaded. I think the only solution, if you want to use the generated content hack, is to use a data-uri with the understanding that is make the sheet a little bigger.

Contributor

kabel commented Sep 27, 2016

Revert back to using a logo url this will cause problems on the first print when the image is not cached. The print will not include the logo until the logo is loaded. I think the only solution, if you want to use the generated content hack, is to use a data-uri with the understanding that is make the sheet a little bigger.

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Sep 28, 2016

Contributor

Cherry-picked this into develop.

Contributor

kabel commented Sep 28, 2016

Cherry-picked this into develop.

@kabel kabel closed this Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment