Improve layout of hidden regions #1020

Merged
merged 11 commits into from Oct 7, 2016

Conversation

Projects
None yet
3 participants
@skoolbus39
Member

skoolbus39 commented Oct 4, 2016

Corrected layout issues for regions that may be conditionally hidden

skoolbus39 added some commits Oct 3, 2016

Remove menu-trigger height
Specific style for .hide-wdn_navigation_wrapper is redundant as menu-trigger height is already defined.
Remove site title padding-bottom (no breadcrumbs)
Additional padding is not necessary when breadcrumbs are not present
Set nav-full bar height when no nav is present
The new value of 40px matches the height of the nav bar when nav menu items are present.
Adjust pos. of nav bar buttons (no breadcrumbs)
When breadcrumbs are present, the menu and share widgets are absolutely positioned 24px (the height of the breadcrumbs) from the top. When breadcrumbs are removed, the value can be changed to 0. The bottom: -44px; rule is no longer useful.
Adjust share widget height (no menu present)
Set height to match the nav bar to vertically center the share widget.
Remove copyright style for footer contact hide
The copyright info is no longer adjacent to the contact info.
@mfairchild365

This comment has been minimized.

Show comment
Hide comment
@mfairchild365

mfairchild365 Oct 4, 2016

Member

@skoolbus39, @kabel pointed out that the navigation button is still shown in the case where #navigation > ul does not exist (no site navigation). It might be good to adjust the styles to only show the button when the .nav_ready class is added to #wdn_wrapper. Thoughts?

Member

mfairchild365 commented Oct 4, 2016

@skoolbus39, @kabel pointed out that the navigation button is still shown in the case where #navigation > ul does not exist (no site navigation). It might be good to adjust the styles to only show the button when the .nav_ready class is added to #wdn_wrapper. Thoughts?

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Oct 4, 2016

Contributor

This is what used to protect the label from showing:

.js { // fouc-fixes
#wdn_navigation_bar {
visibility: hidden;
}
.nav_ready #wdn_navigation_bar {
visibility: visible;
}
}

Contributor

kabel commented Oct 4, 2016

This is what used to protect the label from showing:

.js { // fouc-fixes
#wdn_navigation_bar {
visibility: hidden;
}
.nav_ready #wdn_navigation_bar {
visibility: visible;
}
}

@kabel kabel merged commit aa3649f into unl:develop Oct 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

kabel added a commit that referenced this pull request Oct 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment