New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #1042

Merged
merged 128 commits into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@skoolbus39
Member

skoolbus39 commented Jan 5, 2017

Update framework CSS to conform to IIM code standards

skoolbus39 added some commits Jan 5, 2017

Remove flexbox prefixing function
Prefixing is already handled by the Less Autoprefixer plugin.

@skoolbus39 skoolbus39 requested a review from kabel Jan 5, 2017

Show outdated Hide outdated wdn/templates_4.1/scripts/js-css/extlatin.less
@@ -1,5 +1,5 @@
.wdn-extlatin {
font-family: 'Mercury SSm Ext Latin A', 'Mercury SSm Ext Latin B', Georgia, Baskerville, 'Baskerville Old Face', 'Hoefler Text', Garamond, 'Times New Roman', serif;
font-family: 'Mercury SSm A', 'Mercury SSm B', Georgia, serif;

This comment has been minimized.

@kabel

kabel Jan 6, 2017

Contributor

Did you mean to remove the "Ext Latin" part; aren't these separate fonts?

@kabel

kabel Jan 6, 2017

Contributor

Did you mean to remove the "Ext Latin" part; aren't these separate fonts?

This comment has been minimized.

@skoolbus39

skoolbus39 Jan 6, 2017

Member

I most certainly did not. Great catch.

@skoolbus39

skoolbus39 Jan 6, 2017

Member

I most certainly did not. Great catch.

Show outdated Hide outdated wdn/templates_4.1/scripts/js-css/smallcaps.less
@@ -1,5 +1,5 @@
.wdn-smallcaps {
font-family: 'Mercury SSm Small Caps A', 'Mercury SSm Small Caps B', Georgia, Baskerville, 'Baskerville Old Face', 'Hoefler Text', Garamond, 'Times New Roman', serif;
font-family: 'Mercury SSm A', 'Mercury SSm B', Georgia, serif;

This comment has been minimized.

@kabel

kabel Jan 6, 2017

Contributor

Did you mean to remove the "Small Caps" part?

@kabel

kabel Jan 6, 2017

Contributor

Did you mean to remove the "Small Caps" part?

This comment has been minimized.

@skoolbus39

skoolbus39 Jan 6, 2017

Member

Another great catch. I'll push some updates in just a sec.

@skoolbus39

skoolbus39 Jan 6, 2017

Member

Another great catch. I'll push some updates in just a sec.

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Jan 6, 2017

Contributor

Just an FYI for you. You don't need all these separate commits (looks like you made one per file). Your commits can/should be a logical unit of work being completed. Grouping the files of a related change helps to show the scope of the change(s) you are making.

Contributor

kabel commented Jan 6, 2017

Just an FYI for you. You don't need all these separate commits (looks like you made one per file). Your commits can/should be a logical unit of work being completed. Grouping the files of a related change helps to show the scope of the change(s) you are making.

@kabel kabel merged commit 361eeae into unl:develop Jan 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment