New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple instances of the events-band #792

Merged
merged 3 commits into from Aug 27, 2014

Conversation

Projects
None yet
2 participants
@kabel
Contributor

kabel commented Aug 20, 2014

This makes the plugin more like the other event widget.

@mfairchild365

This comment has been minimized.

Show comment
Hide comment
@mfairchild365

mfairchild365 Aug 20, 2014

Member

Can you add an example of how this would be used?

Member

mfairchild365 commented Aug 20, 2014

Can you add an example of how this would be used?

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Aug 20, 2014

Contributor

This should probably be documented outside of an example in the repo.

<div id="my_calendar1"></div>
<script>
WDN.initializePlugin('events', { url: '//events.unl.edu/calendar/', container: '#my_calendar1', limit: 4 })
</script>
Contributor

kabel commented Aug 20, 2014

This should probably be documented outside of an example in the repo.

<div id="my_calendar1"></div>
<script>
WDN.initializePlugin('events', { url: '//events.unl.edu/calendar/', container: '#my_calendar1', limit: 4 })
</script>
@mfairchild365

This comment has been minimized.

Show comment
Hide comment
@mfairchild365

mfairchild365 Aug 26, 2014

Member

Where where you thinking of documenting this? The WDN site?

Member

mfairchild365 commented Aug 26, 2014

Where where you thinking of documenting this? The WDN site?

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Aug 26, 2014

Contributor

I had no immediate plans on a place to document it. The current site structure does not have good place for it and the WIKI is already is disarray.

Contributor

kabel commented Aug 26, 2014

I had no immediate plans on a place to document it. The current site structure does not have good place for it and the WIKI is already is disarray.

@mfairchild365

This comment has been minimized.

Show comment
Hide comment
@mfairchild365

mfairchild365 Aug 27, 2014

Member

@kabel can you fix this PR and add an entry to the changelog for it? The changelog might be a good place to put a quick example.

Member

mfairchild365 commented Aug 27, 2014

@kabel can you fix this PR and add an entry to the changelog for it? The changelog might be a good place to put a quick example.

mfairchild365 added a commit that referenced this pull request Aug 27, 2014

Merge pull request #792 from kabel/multi-event-band
Allow multiple instances of the events-band

@mfairchild365 mfairchild365 merged commit 1d48e6a into unl:develop Aug 27, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@kabel kabel deleted the kabel:multi-event-band branch Sep 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment