Fix local analytics not working and bad event value #807

Merged
merged 1 commit into from Sep 29, 2014

Conversation

Projects
None yet
2 participants
@kabel
Contributor

kabel commented Sep 29, 2014

  • Event values must be numeric (not strings)
  • Localizing the _gat, _gaq, ga window variables causes problems when
    the Google API asyncronously changes them
Fix local analytics not working and bad event value
* Event values must be numeric (not strings)
* Localizing the _gat, _gaq, ga window variables causes problems when
the Google API asyncronously changes them
link.click(function() {
- Plugin.callTrackEvent('File Download', gahref, thisURL, extension);

This comment has been minimized.

@mfairchild365

mfairchild365 Sep 29, 2014

Member

Just a note that it should be noted in the CHANGELOG that the extension is no longer logged as the value. It appears that this isn't working right now, but was it at one time?

@mfairchild365

mfairchild365 Sep 29, 2014

Member

Just a note that it should be noted in the CHANGELOG that the extension is no longer logged as the value. It appears that this isn't working right now, but was it at one time?

This comment has been minimized.

@kabel

kabel Sep 29, 2014

Contributor

No. It has never worked. Google Analytics has never supported a string based value in its API. It looks like this slipped back in during the conversion from 3.1.

@kabel

kabel Sep 29, 2014

Contributor

No. It has never worked. Google Analytics has never supported a string based value in its API. It looks like this slipped back in during the conversion from 3.1.

mfairchild365 added a commit that referenced this pull request Sep 29, 2014

Merge pull request #807 from kabel/bugfix-local-analytics
Fix local analytics not working and bad event value

@mfairchild365 mfairchild365 merged commit 671c650 into unl:develop Sep 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@kabel kabel deleted the kabel:bugfix-local-analytics branch Sep 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment