New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wdn-icons #809

Merged
merged 3 commits into from Oct 7, 2014

Conversation

Projects
None yet
2 participants
@skoolbus39
Member

skoolbus39 commented Oct 2, 2014

Updated icon font to include some Streamline icon glyphs, added play and pause circled icons.
Adjusted Share icon size/position to account for difference in size of glyph between old icon and new Streamline glyph.

skoolbus39 added some commits Oct 2, 2014

Update icon font
Updated to include some Streamline icon glyphs, added play and pause circled icons.
Adjust Share icon size/position
Adjusted to account for difference in size of glyph between old icon and new Streamline glyph
@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Oct 2, 2014

Contributor

I worry that changing the glyph code changes might have an impact on sites that either don't use the CSS classes or might have a caching issue. What I mean by that is the "Customize Codes" screen on fontello is drastically different with this config file. That is, character \e802 is currently the search glyph but this new config makes it the youtube glyph.

We should do our best to ensure backwards compatibility by mapping the previously used character codes to the proper glyph.

Contributor

kabel commented Oct 2, 2014

I worry that changing the glyph code changes might have an impact on sites that either don't use the CSS classes or might have a caching issue. What I mean by that is the "Customize Codes" screen on fontello is drastically different with this config file. That is, character \e802 is currently the search glyph but this new config makes it the youtube glyph.

We should do our best to ensure backwards compatibility by mapping the previously used character codes to the proper glyph.

kabel added a commit that referenced this pull request Oct 7, 2014

@kabel kabel merged commit b4b859f into unl:develop Oct 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment