Remove CSS from the randomizer plugin. #812

Merged
merged 1 commit into from Oct 9, 2014

Conversation

Projects
None yet
2 participants
@kabel
Contributor

kabel commented Oct 9, 2014

The styles will be added by javascript to avoid problems with loading an
external stylesheet.

Remove CSS from the randomizer plugin.
The styles will be added by javascript to avoid problems with loading an
external stylesheet.
@mfairchild365

This comment has been minimized.

Show comment
Hide comment
@mfairchild365

mfairchild365 Oct 9, 2014

Member

I agree, a style sheet isn't really needed here. However, will loading external stylesheets be a problem for other plugins? Were you able to pinpoint the problem with the stylesheet?

Member

mfairchild365 commented Oct 9, 2014

I agree, a style sheet isn't really needed here. However, will loading external stylesheets be a problem for other plugins? Were you able to pinpoint the problem with the stylesheet?

mfairchild365 added a commit that referenced this pull request Oct 9, 2014

Merge pull request #812 from kabel/cssless-randomizer
Remove CSS from the randomizer plugin.

@mfairchild365 mfairchild365 merged commit e91c5b7 into unl:develop Oct 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@kabel kabel deleted the kabel:cssless-randomizer branch Oct 9, 2014

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Oct 9, 2014

Contributor

It shouldn't be a problem for other plugins. The issue because more complex because of the callback on the loadCSS call. I guessing that's where the race condition happens.

Contributor

kabel commented Oct 9, 2014

It shouldn't be a problem for other plugins. The issue because more complex because of the callback on the loadCSS call. I guessing that's where the race condition happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment