New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkedin share link #821

Merged
merged 5 commits into from Dec 12, 2014

Conversation

Projects
None yet
3 participants
@spennythug
Contributor

spennythug commented Dec 12, 2014

I believe I have done everything correctly here. Let me know if there is anything that should be done differently.

Show outdated Hide outdated wdn/templates_4.0/scripts/socialmediashare.js
@@ -16,6 +16,7 @@ define(['jquery', 'wdn', 'require'], function($, WDN, require) {
templateFacebook = 'https://www.facebook.com/sharer/sharer.php?u=',
// https://dev.twitter.com/docs/tweet-button
templateTwitter = 'https://twitter.com/share?text=' + templateBody + '&via=' + templateVia,
templateLinkedin = 'http://www.linkedin.com/shareArticle?mini=true&summary= '+ templateBody + '&source=' + templateVia,

This comment has been minimized.

@kabel

kabel Dec 12, 2014

Contributor

It might be a good idea to add a comment above this line that includes a URL to LinkedIn's documentation page, so that future developers can quickly find the reference.

@kabel

kabel Dec 12, 2014

Contributor

It might be a good idea to add a comment above this line that includes a URL to LinkedIn's documentation page, so that future developers can quickly find the reference.

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Dec 12, 2014

Contributor

It may be a little nitpicky, but our JS files use tabs instead of spaces.

Contributor

kabel commented Dec 12, 2014

It may be a little nitpicky, but our JS files use tabs instead of spaces.

kabel added a commit that referenced this pull request Dec 12, 2014

@kabel kabel merged commit 41f58a0 into unl:develop Dec 12, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@mfairchild365

This comment has been minimized.

Show comment
Hide comment
Member

mfairchild365 commented Dec 12, 2014

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment