Fix the algorithm of allowing UNL Search URL extending #830

Merged
merged 1 commit into from Mar 10, 2015

Conversation

Projects
None yet
2 participants
@kabel
Contributor

kabel commented Mar 9, 2015

Local sites should only be allowed to append the U or CX querystring
params for use in the WDN search tool.

Logic has been added to enforce the use of ONLY the UNL Search app from
the WDN search tool.

This commit also removes the experimental speak-to-text attribute that
has been removed from the only browser that supported it.

The undocumented feature to add a local placeholder has also been
removed (unapproved by the style guide)

Fix the algorithm of allowing UNL Search URL extending
Local sites should only be allowed to append the U or CX querystring
params for use in the WDN search tool.

Logic has been added to enforce the use of ONLY the UNL Search app from
the WDN search tool.

This commit also removes the experimental speak-to-text attribute that
has been removed from the only browser that supported it.

The undocumented feature to add a local placeholder has also been
removed (unapproved by the style guide)
+ searchPath = '/search/', // path to UNL Search app
+ searchOrigin = window.location.protocol + '//' + searchHost,
+ searchAction = searchOrigin + searchPath,
+ allowSearchParams = ['u', 'cx'], // QS Params allowed by UNL Search app

This comment has been minimized.

@mfairchild365

mfairchild365 Mar 10, 2015

Member

Out of curiosity, what is u? I didn't see it on this list: https://developers.google.com/custom-search/json-api/v1/reference/cse/list

@mfairchild365

mfairchild365 Mar 10, 2015

Member

Out of curiosity, what is u? I didn't see it on this list: https://developers.google.com/custom-search/json-api/v1/reference/cse/list

This comment has been minimized.

@kabel

kabel Mar 10, 2015

Contributor

u is a custom parameter the UNL Search app uses to auto-magically create a Google CSE on-the-fly.

@kabel

kabel Mar 10, 2015

Contributor

u is a custom parameter the UNL Search app uses to auto-magically create a Google CSE on-the-fly.

This comment has been minimized.

@mfairchild365

mfairchild365 Mar 10, 2015

Member

Ah okay. Why would a site want to set it, and what would they set it to?

@mfairchild365

mfairchild365 Mar 10, 2015

Member

Ah okay. Why would a site want to set it, and what would they set it to?

This comment has been minimized.

@kabel

kabel Mar 10, 2015

Contributor

Too allow developers to manually provide a "search root" for their site/sub-site in cases where the default logic (using the site homepage) would result in unexpected/poor local search performance. For example, when the home page of a site is at a file URL rather than a directory.

This is just a stricter enforcement of the previously documented was of defining your local search: http://www1.unl.edu/wdn/wiki/Local_Site_Links#search

@kabel

kabel Mar 10, 2015

Contributor

Too allow developers to manually provide a "search root" for their site/sub-site in cases where the default logic (using the site homepage) would result in unexpected/poor local search performance. For example, when the home page of a site is at a file URL rather than a directory.

This is just a stricter enforcement of the previously documented was of defining your local search: http://www1.unl.edu/wdn/wiki/Local_Site_Links#search

mfairchild365 added a commit that referenced this pull request Mar 10, 2015

Merge pull request #830 from kabel/fix-ux-search
Fix the algorithm of allowing UNL Search URL extending

@mfairchild365 mfairchild365 merged commit 23e90bc into unl:develop Mar 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kabel kabel deleted the kabel:fix-ux-search branch Jul 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment