Email missing link fix #832

Merged
merged 7 commits into from Apr 23, 2015

Conversation

Projects
None yet
2 participants
@spennythug
Contributor

spennythug commented Apr 16, 2015

No description provided.

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Apr 16, 2015

Contributor

This should address #833

Contributor

kabel commented Apr 16, 2015

This should address #833

@@ -95,5 +146,31 @@ define(['jquery', 'wdn', 'require'], function($, WDN, require) {
}
};
+ assembleLink = function(shareId, subject, url, isShort) {

This comment has been minimized.

@kabel

kabel Apr 23, 2015

Contributor

I would put these functions at the top of the file and make sure you add the var prefix to ensure they don't get pushed into the window global scope.

@kabel

kabel Apr 23, 2015

Contributor

I would put these functions at the top of the file and make sure you add the var prefix to ensure they don't get pushed into the window global scope.

kabel added a commit that referenced this pull request Apr 23, 2015

@kabel kabel merged commit 39ddee8 into unl:develop Apr 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment