Extend font features (small caps, extended Latin) #871

Merged
merged 3 commits into from Aug 11, 2015

Conversation

Projects
None yet
2 participants
@skoolbus39
Member

skoolbus39 commented Aug 11, 2015

Extended font features can optionally be included via JavaScript.

Extend font features (small caps, extended Latin)
Extended font features can optionally be included via JavaScript.
wdn/templates_4.0/scripts/extlatin.js
@@ -0,0 +1,14 @@
+define(['jquery', 'wdn', 'require'], function($, WDN, require) {
+
+ // Load Mercury ScreenSmart Extended Latin fonts from Cloud.typography

This comment has been minimized.

@kabel

kabel Aug 11, 2015

Contributor

I'd wrap all of this in the following to make it compatible with the WDN.initializePlugin signature:

var initd = false;

return {
    initializePlugin: function() {
        // protect against multiple initializations
        if (initd) {
            return;
        }
        initd = true;

        [...]
    }
};
@kabel

kabel Aug 11, 2015

Contributor

I'd wrap all of this in the following to make it compatible with the WDN.initializePlugin signature:

var initd = false;

return {
    initializePlugin: function() {
        // protect against multiple initializations
        if (initd) {
            return;
        }
        initd = true;

        [...]
    }
};
wdn/templates_4.0/scripts/smallcaps.js
@@ -0,0 +1,14 @@
+define(['jquery', 'wdn', 'require'], function($, WDN, require) {
+
+ // Load Mercury ScreenSmart Small Caps fonts from Cloud.typography

This comment has been minimized.

@kabel

kabel Aug 11, 2015

Contributor

Same comment from about about compatibility.

@kabel

kabel Aug 11, 2015

Contributor

Same comment from about about compatibility.

kabel added a commit that referenced this pull request Aug 11, 2015

Merge pull request #871 from skoolbus39/fonts
Extend font features (small caps, extended Latin)

@kabel kabel merged commit f47b404 into unl:develop Aug 11, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment