Give #maincontent focus on skipnav click #884

Merged
merged 3 commits into from Aug 28, 2015

Conversation

Projects
None yet
2 participants
@mfairchild365
Member

mfairchild365 commented Aug 28, 2015

This fixes an issue where if the skipnav link was clicked, focus was not being set to the #maincontent div. The screen would just visually focus on the area, rather than move tab focus to the maincontent area.

fixes #829

Give #maincontent focus on skipnav click
This fixes an issue where if the skipnav link was clicked, focus was not being set to the #maincontent div.  The screen would just visually focus on the area, rather than move tab focus to the maincontent area.
@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Aug 28, 2015

Contributor

This is good for now. I'd love to see something more like what was done in Sheldon, by removing the attribute on blur.

Contributor

kabel commented Aug 28, 2015

This is good for now. I'd love to see something more like what was done in Sheldon, by removing the attribute on blur.

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Aug 28, 2015

Contributor

Problem: You changed the order of the main dependencies, and thus the callback parameters don't match.

Contributor

kabel commented Aug 28, 2015

Problem: You changed the order of the main dependencies, and thus the callback parameters don't match.

@mfairchild365

This comment has been minimized.

Show comment
Hide comment
@mfairchild365

mfairchild365 Aug 28, 2015

Member

@kabel can you link me to what was done with Sheldon, I can't find it.

Member

mfairchild365 commented Aug 28, 2015

@kabel can you link me to what was done with Sheldon, I can't find it.

@kabel

This comment has been minimized.

Show comment
Hide comment
@kabel

kabel Aug 28, 2015

Contributor

Private repo link shared out-of-band.

Contributor

kabel commented Aug 28, 2015

Private repo link shared out-of-band.

mfairchild365 added some commits Aug 28, 2015

Fix the order of modules
Fixes broken tests
Wait until the document is ready
#maincontent might not exist yet.

kabel added a commit that referenced this pull request Aug 28, 2015

Merge pull request #884 from mfairchild365/skip-nav
Give #maincontent focus on skipnav click

@kabel kabel merged commit a6cb5d5 into unl:develop Aug 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment