New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed position share menu on scroll #976

Merged
merged 3 commits into from Mar 30, 2016

Conversation

Projects
None yet
2 participants
@skoolbus39
Member

skoolbus39 commented Mar 30, 2016

FYI: I thought I had undid commit 1a61334, but it is included (and changed by a subsequent commit) here. I don't think its inclusion necessarily hurts anything.

I will continue to work on visual improvements related to this update before (and possibly after, too) deployment next week.

skoolbus39 added some commits Mar 29, 2016

Fixed position share menu on scroll
Fixes #974 Share popup does not stick with the nav and icon
Add fixed positioning to share menu on scroll
* Removed redundant z-index (declared on line 2 of layouts/share.less)
* Removed redundant top and fixed positioning (already handled by .wdn-menu-trigger's flexbox align:center and fixed: position)
* Didn't remove transition property (yet?) as difficult to test due to issue #973
* Positioning of share menu popup could still be improved for desktop

Fixes issue #974 Share popup does not stick with the nav and icon
Remove redundant styles
* Padding, color already declared in layouts/navigation.less

@kabel kabel merged commit c2ed8e0 into unl:develop Mar 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment