New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some more network requests #977

Merged
merged 2 commits into from Mar 30, 2016

Conversation

Projects
None yet
2 participants
@kabel
Copy link
Contributor

kabel commented Mar 30, 2016

Removes 2 network requests for css related items (print sheet and large SVG image).

kabel added some commits Mar 24, 2016

Fix seal.svg loaded as image instead of data URI.
The SVG is too big for IE 8 data uri, so we need to pass an option to
less to confirm we do not need that support.
Move print styles into all css file.
Browsers load them anyway, so we should save the extra network request.

@kabel kabel changed the title Remove some more network request Remove some more network requests Mar 30, 2016

@skoolbus39

This comment has been minimized.

Copy link
Member

skoolbus39 commented Mar 30, 2016

Looks like you're missing a new line at the end of your print.less file

@kabel

This comment has been minimized.

Copy link
Contributor

kabel commented Mar 30, 2016

Nope. It's there. If it wasn't there, GitHub would say so at the end of the diff.

@skoolbus39

This comment has been minimized.

Copy link
Member

skoolbus39 commented Mar 30, 2016

Weird. When viewing a file in GitHub it doesn't show the final line. I never noticed that before.

@skoolbus39 skoolbus39 merged commit 72bcf10 into develop Mar 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kabel kabel deleted the critical-path-opt branch Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment