New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wdn-hero content module #980

Merged
merged 3 commits into from Apr 5, 2016

Conversation

Projects
None yet
3 participants
@skoolbus39
Copy link
Member

skoolbus39 commented Apr 1, 2016

No description provided.

@skoolbus39

This comment has been minimized.

Copy link
Member

skoolbus39 commented Apr 4, 2016

This still needs to include the Picturefill polyfill for the picture element before deployment.

@mfairchild365

This comment has been minimized.

Copy link
Contributor

mfairchild365 commented Apr 4, 2016

Not necessary for this PR, but this could use some documentation love on the WDN site too.

@skoolbus39

This comment has been minimized.

Copy link
Member

skoolbus39 commented Apr 4, 2016

I started the documentation, but have held off until we decide on how to handle the Picturefill polyfill.

Adjust allow for use of srcset/sizes
Styling to allow for picture element (.wdn-hero-picture) with source and img, or img (.wdn-hero-poster) with srcset and sizes
@skoolbus39

This comment has been minimized.

Copy link
Member

skoolbus39 commented Apr 5, 2016

We've decided not to implement the Picturefill polyfill for this release.

@kabel kabel merged commit 02ff4fe into unl:develop Apr 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment