Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of node.js url in unmock-core. #314

Merged
merged 6 commits into from Oct 16, 2019

Conversation

@ksaaskil
Copy link
Contributor

ksaaskil commented Oct 14, 2019

To fix issues where require("url") fails because running outside of Node.js. We want unmock-core to be "isomorphic" in that it can run in Node, browser, React Native, etc.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #314 into dev will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev    #314   +/-   ##
=====================================
  Coverage   59.1%   59.1%           
=====================================
  Files         56      56           
  Lines       2213    2213           
  Branches     563     563           
=====================================
  Hits        1308    1308           
  Misses       905     905
Impacted Files Coverage Δ
packages/unmock-core/src/generator.ts 64.28% <100%> (ø) ⬆️
packages/unmock-core/src/service/serviceStore.ts 26.92% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0864e...a2a0289. Read the comment docs.

@ksaaskil ksaaskil marked this pull request as ready for review Oct 14, 2019
@ksaaskil ksaaskil requested a review from carolstran Oct 14, 2019
Copy link
Contributor

mikesol left a comment

Great stuff, thanks!

@ksaaskil ksaaskil merged commit cbb69d6 into dev Oct 16, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: verify-before-publish Your tests passed on CircleCI!
Details
@ksaaskil ksaaskil deleted the remove-url branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.