New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing Readonly with Const::Fast #4

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@garu
Contributor

garu commented Jul 12, 2015

Hello!

This is another very simple patch to WWW::Facebook::API, replacing the deprecated Readonly module with the newer Const::Fast.

According to Const::Fast's documentation, there are some serious issues of Readonly that aren't easily fixable without breaking backwards compatibility in subtle ways. In particular Readonly's use of ties is a source of subtle bugs and bad performance. Instead, Const::Fast uses the builtin readonly feature of perl, making access to the variables just as fast as any normal variable without the weird side-effects of ties. Readonly can do the same for scalars when Readonly::XS is installed, but chooses not to do so in the most common case.

Hope it helps! Cheers!

@unobe unobe merged commit 9e80145 into unobe:master Aug 3, 2016

@unobe

This comment has been minimized.

Show comment
Hide comment
@unobe

unobe Aug 3, 2016

Owner

Thanks!

Owner

unobe commented Aug 3, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment