Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pathe #1632

Merged
merged 6 commits into from Sep 26, 2022
Merged

fix: use pathe #1632

merged 6 commits into from Sep 26, 2022

Conversation

sudongyuer
Copy link
Member

@sudongyuer sudongyuer commented Sep 25, 2022

No description provided.

@sudongyuer sudongyuer requested a review from antfu as a code owner Sep 25, 2022
@netlify
Copy link

netlify bot commented Sep 25, 2022

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 90158e2
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/63310baf0a37c30009b19585
😎 Deploy Preview https://deploy-preview-1632--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -69,6 +69,9 @@
"dev": "tsup --watch src",
"publish": "esno ./scripts/publish.ts"
},
"dependencies": {
"pathe": "^0.3.7"
Copy link
Member

@antfu antfu Sep 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go devDeps as VS Code is not a npm package.

Copy link
Member Author

@sudongyuer sudongyuer Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@antfu
Copy link
Member

antfu commented Sep 25, 2022

Is there any real issue to be resolved by this?

@sudongyuer
Copy link
Member Author

sudongyuer commented Sep 26, 2022

Is there any real issue to be resolved by this?
When i write some tests on windows to contribute, be possible to occur.
image

@antfu antfu changed the title chore: enhance platform path compatibility fix: use pathe Sep 26, 2022
antfu
antfu approved these changes Sep 26, 2022
@antfu antfu merged commit 48263d7 into unocss:main Sep 26, 2022
8 checks passed
ydcjeff pushed a commit that referenced this pull request Sep 28, 2022
* chore: revert vscode pathe

* Revert "fix: use `pathe` (#1632)"

This reverts commit 48263d7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants