Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): windows pathe format #1645

Merged
merged 2 commits into from Sep 26, 2022
Merged

fix(vscode): windows pathe format #1645

merged 2 commits into from Sep 26, 2022

Conversation

azaleta
Copy link
Contributor

@azaleta azaleta commented Sep 26, 2022

Linked issue: #1644

Linked Commit: #1632

function pathe:dirname will change the slash of path
https://github.com/unjs/pathe/blob/main/test/index.spec.ts#L86

This cause unequal on Windows and could not load config file.
image

@azaleta azaleta requested a review from antfu as a code owner Sep 26, 2022
@netlify
Copy link

netlify bot commented Sep 26, 2022

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e5bda6
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6331cb22bf1ca20009a2fdbf
😎 Deploy Preview https://deploy-preview-1645--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sudongyuer sudongyuer self-requested a review Sep 26, 2022
@zyyv zyyv linked an issue Sep 26, 2022 that may be closed by this pull request
packages/vscode/src/contextLoader.ts Outdated Show resolved Hide resolved
@sudongyuer
Copy link
Member

sudongyuer commented Sep 26, 2022

@chris-zhu do you think it's necessary to remove pathe.

@antfu antfu merged commit 6183d1b into unocss:main Sep 26, 2022
8 checks passed
@azaleta azaleta deleted the vscode-config branch Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode extension doesn't work after upgrating to 0.45.23
4 participants