Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-wind): sticky hover #1710

Merged
merged 3 commits into from Oct 10, 2022
Merged

feat(preset-wind): sticky hover #1710

merged 3 commits into from Oct 10, 2022

Conversation

chu121su12
Copy link
Collaborator

Thanks to #1681 this PR introduces sticky hover as a standalone variant. The sigil was @ instead of & as in the linked issue.
However, due to its standalone nature, there's no integration with css functions available in pseudo so chaining this variant may require variable variant.

@netlify
Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit ec34f06
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/63438d3281d8e7000984d3f9
😎 Deploy Preview https://deploy-preview-1710--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chu121su12 chu121su12 marked this pull request as ready for review October 9, 2022 06:28
@chu121su12 chu121su12 requested a review from antfu as a code owner October 9, 2022 06:28
zyyv
zyyv approved these changes Oct 10, 2022
antfu
antfu approved these changes Oct 10, 2022
@antfu antfu enabled auto-merge (squash) October 10, 2022 03:11
antfu
antfu approved these changes Oct 10, 2022
@antfu antfu merged commit 872d7ee into unocss:main Oct 10, 2022
11 checks passed
@chu121su12 chu121su12 deleted the feat/hover branch October 25, 2022 09:55
@zyyv
Copy link
Member

zyyv commented Jan 28, 2023

@chu121su12 Hi, can you help @hover compatibility problem with pseudo, like group-@hover peer-@hover, or another logic to resovle it. I'm sorry I can't fix this 😢.

@chu121su12
Copy link
Collaborator Author

@zyyv Those pseudos need modifier, so you'd want to add something like:

peer-invalid-@hover

I'm uncertain if originally the pseudos can work without modifier.

https://tailwindcss.com/docs/hover-focus-and-other-states#styling-based-on-parent-state
https://tailwindcss.com/docs/hover-focus-and-other-states#styling-based-on-sibling-state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants