From b80e23d4bf8cf7bf6f86ac2a6e6f857aaa9dee4f Mon Sep 17 00:00:00 2001 From: Youssef Victor Date: Fri, 17 May 2024 19:46:03 +0300 Subject: [PATCH] chore: Address review comments --- build/nuget/Uno.WinUI.DevServer.nuspec | 16 +-- build/nuget/Uno.WinUI.Lottie.nuspec | 12 +- build/nuget/Uno.WinUI.MSAL.nuspec | 8 +- build/nuget/Uno.WinUI.RemoteControl.nuspec | 4 +- build/nuget/Uno.WinUI.Svg.nuspec | 12 +- build/nuget/Uno.WinUI.XamlHost.nuspec | 12 +- build/nuget/Uno.WinUI.nuspec | 118 +++++++++--------- src/Directory.Build.props | 4 +- .../Uno.UI.Maps.netcoremobile.csproj | 2 +- src/targetframework-override.props | 2 + src/uno.mobile-cross-targeting-disable.props | 4 +- 11 files changed, 98 insertions(+), 96 deletions(-) diff --git a/build/nuget/Uno.WinUI.DevServer.nuspec b/build/nuget/Uno.WinUI.DevServer.nuspec index d35dc150be72..b301c8701ff9 100644 --- a/build/nuget/Uno.WinUI.DevServer.nuspec +++ b/build/nuget/Uno.WinUI.DevServer.nuspec @@ -25,8 +25,8 @@ - - + + @@ -61,8 +61,8 @@ - - + + @@ -136,8 +136,8 @@ - - + + @@ -148,8 +148,8 @@ - - + + diff --git a/build/nuget/Uno.WinUI.Lottie.nuspec b/build/nuget/Uno.WinUI.Lottie.nuspec index 7f63c3f1b964..96d07d8ee659 100644 --- a/build/nuget/Uno.WinUI.Lottie.nuspec +++ b/build/nuget/Uno.WinUI.Lottie.nuspec @@ -47,7 +47,7 @@ - + @@ -80,7 +80,7 @@ - + @@ -102,7 +102,7 @@ - + @@ -114,7 +114,7 @@ - + @@ -139,11 +139,11 @@ - + - + diff --git a/build/nuget/Uno.WinUI.MSAL.nuspec b/build/nuget/Uno.WinUI.MSAL.nuspec index c0f5632f8184..54f31c7450bb 100644 --- a/build/nuget/Uno.WinUI.MSAL.nuspec +++ b/build/nuget/Uno.WinUI.MSAL.nuspec @@ -42,7 +42,7 @@ - + @@ -58,7 +58,7 @@ - + @@ -85,12 +85,12 @@ - + - + diff --git a/build/nuget/Uno.WinUI.RemoteControl.nuspec b/build/nuget/Uno.WinUI.RemoteControl.nuspec index f2db8c6e2292..3bcd14168267 100644 --- a/build/nuget/Uno.WinUI.RemoteControl.nuspec +++ b/build/nuget/Uno.WinUI.RemoteControl.nuspec @@ -31,12 +31,12 @@ - + - + diff --git a/build/nuget/Uno.WinUI.Svg.nuspec b/build/nuget/Uno.WinUI.Svg.nuspec index 7a2dd9dfad83..e17eeee38227 100644 --- a/build/nuget/Uno.WinUI.Svg.nuspec +++ b/build/nuget/Uno.WinUI.Svg.nuspec @@ -41,7 +41,7 @@ - + @@ -63,7 +63,7 @@ - + @@ -76,7 +76,7 @@ - + @@ -88,7 +88,7 @@ - + @@ -106,11 +106,11 @@ - + - + diff --git a/build/nuget/Uno.WinUI.XamlHost.nuspec b/build/nuget/Uno.WinUI.XamlHost.nuspec index 06128e0390ef..4dc103c7e879 100644 --- a/build/nuget/Uno.WinUI.XamlHost.nuspec +++ b/build/nuget/Uno.WinUI.XamlHost.nuspec @@ -19,7 +19,7 @@ - + @@ -31,7 +31,7 @@ - + @@ -46,8 +46,8 @@ - - + + @@ -58,8 +58,8 @@ - - + + diff --git a/build/nuget/Uno.WinUI.nuspec b/build/nuget/Uno.WinUI.nuspec index bbe79becaa00..93c4c4f936da 100644 --- a/build/nuget/Uno.WinUI.nuspec +++ b/build/nuget/Uno.WinUI.nuspec @@ -43,8 +43,8 @@ - - + + @@ -76,8 +76,8 @@ - - + + @@ -159,8 +159,8 @@ - - + + @@ -221,7 +221,7 @@ - + @@ -301,7 +301,7 @@ - + @@ -321,30 +321,30 @@ - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + @@ -424,30 +424,30 @@ - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + @@ -659,7 +659,7 @@ - + @@ -670,11 +670,11 @@ - + - + diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 1432c57dac10..de36d3baa29c 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -54,8 +54,8 @@ net9.0 net8.0 - $(NetCurrent)-android;$(NetCurrent)-ios17.2;$(NetCurrent)-maccatalyst;$(NetCurrent)-macos - $(NetPrevious)-android;$(NetPrevious)-ios17.0;$(NetPrevious)-maccatalyst;$(NetPrevious)-macos + $(NetCurrent)-android;$(NetCurrent)-ios17.2;$(NetCurrent)-maccatalyst17.2;$(NetCurrent)-macos + $(NetPrevious)-android;$(NetPrevious)-ios17.0;$(NetPrevious)-maccatalyst17.0;$(NetPrevious)-macos $(NetPrevious)-windows $(NetCurrent)-windows diff --git a/src/Uno.UI.Maps/Uno.UI.Maps.netcoremobile.csproj b/src/Uno.UI.Maps/Uno.UI.Maps.netcoremobile.csproj index 812cfd0a3baf..5aedaab9f06d 100644 --- a/src/Uno.UI.Maps/Uno.UI.Maps.netcoremobile.csproj +++ b/src/Uno.UI.Maps/Uno.UI.Maps.netcoremobile.csproj @@ -1,6 +1,6 @@  - $(NetPrevious)-android;$(NetPrevious)-ios;$(NetPrevious)-maccatalyst + $(NetPrevious)-android;$(NetPrevious)-ios17.0;$(NetPrevious)-maccatalyst17.0 diff --git a/src/targetframework-override.props b/src/targetframework-override.props index 66961a510e7d..aff2be8f666d 100644 --- a/src/targetframework-override.props +++ b/src/targetframework-override.props @@ -4,6 +4,8 @@ $(UnoTargetFrameworkOverride) net8.0-ios17.0 net9.0-ios17.2 + net8.0-maccatalyst17.0 + net9.0-maccatalyst.2 diff --git a/src/uno.mobile-cross-targeting-disable.props b/src/uno.mobile-cross-targeting-disable.props index df6580524534..caa5fc21a223 100644 --- a/src/uno.mobile-cross-targeting-disable.props +++ b/src/uno.mobile-cross-targeting-disable.props @@ -1,7 +1,7 @@ - <_UnoFilteredTargetFrameworks>$(TargetFrameworks.Replace('net8.0-ios17.0','').Replace('net8.0-android','').Replace('net8.0-maccatalyst','').Replace('net8.0-macos','').Trim(';')) + <_UnoFilteredTargetFrameworks>$(TargetFrameworks.Replace('net8.0-ios17.0','').Replace('net8.0-android','').Replace('net8.0-maccatalyst17.0','').Replace('net8.0-macos','').Trim(';'))